[
https://issues.apache.org/jira/browse/AVRO-3248?focusedWorklogId=680573&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680573
]
ASF GitHub Bot logged work on AVRO-3248:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/21 01:40
Start Date: 12/Nov/21 01:40
Worklog Time Spent: 10m
Work Description: lulitao1997 opened a new pull request #1396:
URL: https://github.com/apache/avro/pull/1396
change Value::Union to value it holds and its position in the type list,
this allows us to
Make sure you have checked _all_ steps below.
### Jira
- [x ] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO-3248) issues and references
them in the PR title.
### Tests
- [ x] My PR adds the following unit tests
1. schema::tests::test_union_of_records
2. schema::tests::test_nullable_record
### Commits
- [x ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 680573)
Time Spent: 20m (was: 10m)
> Rust: Support named types in UnionSchema
> ----------------------------------------
>
> Key: AVRO-3248
> URL: https://issues.apache.org/jira/browse/AVRO-3248
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Lu Litao
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> currently there's no support for named type in avro's Union type in rust.
> as stated in this comment of the UnionSchma struct
> {quote}// Used to ensure uniqueness of schema inputs, and provide constant
> time finding of the
> // schema index given a value.
> // **NOTE** that this approach does not work for named types, and will have
> to be modified
> // to support that. A simple solution is to also keep a mapping of the names
> used.
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
