[ 
https://issues.apache.org/jira/browse/AVRO-2019?focusedWorklogId=694726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694726
 ]

ASF GitHub Bot logged work on AVRO-2019:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Dec/21 11:43
            Start Date: 12/Dec/21 11:43
    Worklog Time Spent: 10m 
      Work Description: RyanSkraba commented on a change in pull request #1413:
URL: https://github.com/apache/avro/pull/1413#discussion_r767262400



##########
File path: doc/src/content/xdocs/idl.xml
##########
@@ -252,6 +252,14 @@ record Job {
   time_ms submitTime;
   timestamp_ms finishTime;
   decimal(9,2) finishRatio;
+}
+        </source>
+        <p>Logical types can also be specified via an annotation, which is 
useful for logical types for which a keyword does not exist:</p>
+        <source>
+record Job {
+  string jobid;
+  @logicalType("timestamp-micros")
+  long finishTime;

Review comment:
       Thanks @martin-g !




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 694726)
    Time Spent: 50m  (was: 40m)

> Improve documentation for logical type annotations in IDL
> ---------------------------------------------------------
>
>                 Key: AVRO-2019
>                 URL: https://issues.apache.org/jira/browse/AVRO-2019
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: doc, logical types
>            Reporter: Andrew Rosca
>            Assignee: Andrew Rosca
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.11.1
>
>         Attachments: AVRO-2019.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The IDL documentation lacks information for how annotations can be specified 
> for logical types, like in the following example:
> {code}
> protocol test {
>     record test {
>         @logicalType("timestamp-millis")
>         long time;
>     }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to