[
https://issues.apache.org/jira/browse/AVRO-3302?focusedWorklogId=711123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711123
]
ASF GitHub Bot logged work on AVRO-3302:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/22 06:47
Start Date: 19/Jan/22 06:47
Worklog Time Spent: 10m
Work Description: martin-g commented on pull request #1456:
URL: https://github.com/apache/avro/pull/1456#issuecomment-1016134355
Tested arrow-datafusion:
```diff
diff --git datafusion/Cargo.toml datafusion/Cargo.toml
index d5334130..bf1634d4 100644
--- datafusion/Cargo.toml
+++ datafusion/Cargo.toml
@@ -74,7 +74,8 @@ regex = { version = "^1.4.3", optional = true }
lazy_static = { version = "^1.4.0" }
smallvec = { version = "1.6", features = ["union"] }
rand = "0.8"
-avro-rs = { version = "0.13", features = ["snappy"], optional = true }
+#avro-rs = { version = "0.13", features = ["snappy"], optional = true }
+avro-rs = { git = "https://github.com/martin-g/avro";,
branch="avro-3302-add-interop-tests-for-rust", features = ["snappy"], optional
= true }
num-traits = { version = "0.2", optional = true }
pyo3 = { version = "0.14", optional = true }
tempfile = "3"
diff --git datafusion/src/avro_to_arrow/schema.rs
datafusion/src/avro_to_arrow/schema.rs
index 2e9a17de..fd0ffc31 100644
--- datafusion/src/avro_to_arrow/schema.rs
+++ datafusion/src/avro_to_arrow/schema.rs
@@ -61,6 +61,7 @@ fn schema_to_field_with_props(
) -> Result<Field> {
let mut nullable = nullable;
let field_type: DataType = match schema {
+ AvroSchema::Ref { name: _ }=> todo!(),
AvroSchema::Null => DataType::Null,
AvroSchema::Boolean => DataType::Boolean,
AvroSchema::Int => DataType::Int32,
```
```
arrow-datafusion on master [!] via 🦀 v1.58.0 on ☁️ eu-central-1 took 10s
❯ cargo run --example avro_sql --features=datafusion/avro
Compiling rustversion v1.0.6
Compiling strum_macros v0.23.1
Compiling avro-rs v0.14.0
(https://github.com/martin-g/avro?branch=avro-3302-add-interop-tests-for-rust#6ee4d8ee)
Compiling datafusion v6.0.0
(/home/martin/git/rust/avro_regression_tests/arrow-datafusion/datafusion)
Compiling datafusion-examples v5.0.0
(/home/martin/git/rust/avro_regression_tests/arrow-datafusion/datafusion-examples)
Finished dev [unoptimized + debuginfo] target(s) in 45.93s
Running `target/debug/examples/avro_sql`
+---------+------------+----------------------------------------------+
| int_col | double_col | CAST(alltypes_plain.date_string_col AS Utf8) |
+---------+------------+----------------------------------------------+
| 1 | 10.1 | 03/01/09 |
| 1 | 10.1 | 04/01/09 |
| 1 | 10.1 | 02/01/09 |
+---------+------------+----------------------------------------------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 711123)
Time Spent: 1h 10m (was: 1h)
> Rust: Implement interop tests for the Rust module
> -------------------------------------------------
>
> Key: AVRO-3302
> URL: https://issues.apache.org/jira/browse/AVRO-3302
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> It would be good to add interop tests for the Rust module.
> This will show if some functionality is still missing and prevent regressions
> in the future!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
