[
https://issues.apache.org/jira/browse/AVRO-3345?focusedWorklogId=718721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718721
]
ASF GitHub Bot logged work on AVRO-3345:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/22 14:44
Start Date: 01/Feb/22 14:44
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on a change in pull request
#1495:
URL: https://github.com/apache/avro/pull/1495#discussion_r796666771
##########
File path: lang/csharp/src/apache/main/File/DataFileConstants.cs
##########
@@ -21,9 +21,6 @@ namespace Avro.File
/// <summary>
/// Constants used in data files.
/// </summary>
- [System.Diagnostics.CodeAnalysis.SuppressMessage("Design",
- "CA1052:Static holder types should be Static or NotInheritable",
- Justification = "Maintain public API")]
Review comment:
It was, but it's an old rule. The way you get rid of it, is just make
the static property readonly. Allows you to essentially make a static property
a constant. The reason you do this is because constants are basic types and
not a reference type like an array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 718721)
Time Spent: 0.5h (was: 20m)
> Resolve unnecessary suppression of CA1052 in DataFileConstants
> --------------------------------------------------------------
>
> Key: AVRO-3345
> URL: https://issues.apache.org/jira/browse/AVRO-3345
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This specifically revolves around the byte array Magic. It just needs to be
> marked readonly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
