[ 
https://issues.apache.org/jira/browse/AVRO-3359?focusedWorklogId=720754&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720754
 ]

ASF GitHub Bot logged work on AVRO-3359:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Feb/22 09:20
            Start Date: 04/Feb/22 09:20
    Worklog Time Spent: 10m 
      Work Description: martin-g commented on a change in pull request #1510:
URL: https://github.com/apache/avro/pull/1510#discussion_r799291240



##########
File path: lang/csharp/src/apache/main/File/DeflateCodec.cs
##########
@@ -88,9 +96,7 @@ public override string GetName()
         /// <inheritdoc/>
         public override bool Equals(object other)
         {
-            if (this == other)
-                return true;
-            return this.GetType().Name == other.GetType().Name;
+            return this == other ? true : GetType().Name == 
other.GetType().Name;

Review comment:
       ```suggestion
               return this == other || GetType().Name == other.GetType().Name;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 720754)
    Time Spent: 20m  (was: 10m)

> Updated formatting in DeflateCodec
> ----------------------------------
>
>                 Key: AVRO-3359
>                 URL: https://issues.apache.org/jira/browse/AVRO-3359
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.11.1
>            Reporter: Kyle Schoonover
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Update Documentation
> Fix spacing formatting
> simplify if statement in Equals(object other)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to