[ https://issues.apache.org/jira/browse/AVRO-3453?focusedWorklogId=744751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744751 ]
ASF GitHub Bot logged work on AVRO-3453: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Mar/22 18:38 Start Date: 20/Mar/22 18:38 Worklog Time Spent: 10m Work Description: zcsizmadia commented on pull request #1605: URL: https://github.com/apache/avro/pull/1605#issuecomment-1073308192 I did my diligence and looked at the generatedcodeattribute. It is part system.runtime.dll that is the reason this will not break. The namespace suggested that is part of the system.codedom package. Which would have been a dealbreaker for this, however it is not. the attribute is added only to the high level objects lome classes and enums ... right? Sealing the classes is a big no IMO. If this attribute prohibits inheritance, that we cannot use this, however it seems the attribute does not prevent inheriting from the class. Just please confirm that from the generated classes can be inherited from and add unit testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 744751) Time Spent: 2h 10m (was: 2h) > C# Avrogen Add Generated Code Attribute > --------------------------------------- > > Key: AVRO-3453 > URL: https://issues.apache.org/jira/browse/AVRO-3453 > Project: Apache Avro > Issue Type: Improvement > Components: csharp > Affects Versions: 1.11.1 > Reporter: Kyle Schoonover > Priority: Minor > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > Development environments that use Code Analysis or something similar attempt > to exclude auto generated code. By adding this attribute to generated > classes, code analysis will skip over evaluating the code. -- This message was sent by Atlassian Jira (v8.20.1#820001)