[
https://issues.apache.org/jira/browse/AVRO-3475?focusedWorklogId=749347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749347
]
ASF GitHub Bot logged work on AVRO-3475:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/22 13:53
Start Date: 29/Mar/22 13:53
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1626:
URL: https://github.com/apache/avro/pull/1626#issuecomment-1081900947
@RyanSkraba @martin-g As indicated in the ticket, this PR changes some
exception message (minor) and throws exceptiosn where the original code did not
(if time-millis and time-micors values are negative). So it might make sense to
include this in 1.12.0, however since the changes are relatively harmless, the
case can be made to include this before 1.12.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 749347)
Remaining Estimate: 23.5h (was: 23h 40m)
Time Spent: 0.5h (was: 20m)
> Enforce time-millis and time-micros specification
> -------------------------------------------------
>
> Key: AVRO-3475
> URL: https://issues.apache.org/jira/browse/AVRO-3475
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Zoltan Csizmadia
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.12.0
>
> Original Estimate: 24h
> Time Spent: 0.5h
> Remaining Estimate: 23.5h
>
> During fixing AVRO-3471, I noticed that negative in/long values or negative
> TimeSpan values are allowed for time-millis and time-micros.
> [https://avro.apache.org/docs/current/spec.html] states that, it is supposed
> to be the number of us/ms after midnight 00:00:00. The following TimSpan
> values do not cause any overflow exceptions:
>
> "-00:00:00.001"
> "-999999.00:00:00"
>
> # This change should throw exceptions in cases where the code has not thrown
> exceptions before
> # OutOfRange exception message should be changed to `'time-millis/micros'
> value must be at least '00:00:00' and less than '1.00:00:00'.` to reflect the
> spec precisely
>
> It might make sense to introduce this change only in 1.12.0, because of all
> the above changes
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
