[
https://issues.apache.org/jira/browse/AVRO-3458?focusedWorklogId=749841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-749841
]
ASF GitHub Bot logged work on AVRO-3458:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/22 05:02
Start Date: 30/Mar/22 05:02
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on a change in pull request
#1606:
URL: https://github.com/apache/avro/pull/1606#discussion_r838119832
##########
File path: lang/csharp/src/apache/test/Generic/GenericRecordTests.cs
##########
@@ -0,0 +1,202 @@
+using System;
+using System.Collections.Generic;
+using Avro.Generic;
+using NUnit.Framework;
+
+namespace Avro.test.Generic
+{
+ [TestFixture]
+ public class GenericRecordTests
+ {
+ private const string baseSchema =
"{\"type\":\"record\",\"name\":\"r\",\"fields\":" +
+
"[{\"name\":\"f2\",\"type\":\"int\"},{\"name\":\"f1\",\"type\":\"boolean\"}]}";
+
+ [Test]
+ public void TestAddByFieldNameThrows()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+
+ // Field does not exist
+ Assert.Throws<AvroException>(() => { genericRecord.Add("badField",
"test"); });
+ }
+
+ [Test]
+ public void TestAddByPosition()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+
+ genericRecord.Add(0, 2);
+
+ object value = genericRecord.GetValue(0);
+
+ Assert.IsNotNull(value);
+ Assert.IsTrue(value is int);
+ Assert.AreEqual(2, (int)value);
+ }
+
+ [Test]
+ public void TestAddByPositionThrows()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+
+ Assert.Throws<IndexOutOfRangeException>(() => {
genericRecord.Add(2, 2); });
+ }
+
+ [Test]
+ public void TestEquals()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+ GenericRecord genericRecord2 = GetBaseGenericRecord();
+
+ Assert.IsTrue(genericRecord.Equals(genericRecord2));
+ }
+
+ [Test]
+ public void TestEqualsNotEqual()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+ GenericRecord genericRecord2 = GetBaseGenericRecord();
+ genericRecord2.Add(0, 2);
+
+ Assert.IsFalse(genericRecord.Equals(genericRecord2));
+ }
+
+ [Test]
+ public void TestEqualsObject()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+ object genericRecord2 = genericRecord;
+
+ Assert.IsTrue(genericRecord.Equals(genericRecord2));
+ }
+
+ [Test]
+ public void TestEqualsObjectNotEqual()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+ GenericRecord genericRecord2 = GetBaseGenericRecord();
+ genericRecord2.Add(0, 2);
+
+ Assert.IsFalse(genericRecord.Equals((object)genericRecord2));
+ }
+
+ [Test]
+ public void TestEqualsObjectNullObject()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+
+ Assert.IsFalse(genericRecord.Equals((object)null));
+ }
+
+ [Test]
+ public void TestGetHashCode()
+ {
+ int hashCode = GetBaseGenericRecord().GetHashCode();
+ Assert.IsTrue(hashCode > 0);
+ }
+
+ [Test]
+ public void TestGetValue()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+
+ object value = genericRecord.GetValue(0);
+
+ Assert.IsNotNull(value);
+ Assert.IsTrue(value is int);
+ Assert.AreEqual(1, (int)value);
+ }
+
+ [Test]
+ public void TestKeyValueLookup()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+
+ // Key Exists
+ object existingKey = genericRecord["f2"];
+ Assert.IsNotNull(existingKey);
+ Assert.IsTrue(existingKey is int);
+ }
+
+ [Test]
+ public void TestKeyValueLookupThrows()
+ {
+ GenericRecord genericRecord = GetBaseGenericRecord();
+
+ // Key does not exist
+ Assert.Throws<KeyNotFoundException>(() => { object missingKey =
genericRecord["badField"]; });
Review comment:
Changed to discard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 749841)
Time Spent: 1h 10m (was: 1h)
> Add test coverage for GenericRecord
> -----------------------------------
>
> Key: AVRO-3458
> URL: https://issues.apache.org/jira/browse/AVRO-3458
> Project: Apache Avro
> Issue Type: Sub-task
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Add additional test coverage for GenericRecord.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
