[
https://issues.apache.org/jira/browse/AVRO-3486?focusedWorklogId=755196&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755196
]
ASF GitHub Bot logged work on AVRO-3486:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/22 12:10
Start Date: 11/Apr/22 12:10
Worklog Time Spent: 10m
Work Description: opwvhk opened a new pull request, #1637:
URL: https://github.com/apache/avro/pull/1637
When parsing or creating a protocol, use both the name and namespace
given to determine the actual name, namespace and fullName.
Reason: the spec says "The name and namespace qualification rules
defined for schema objects apply to protocols as well."
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3486
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR ~adds~ updates the following unit tests __OR__ does not need
testing for this extremely good reason:
`org.apache.avro.compiler.idl.TestIdl#runTests()` for `import.avdl` and
`nestedimport.avdl` by updating `bar.avpr`
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
Issue Time Tracking
-------------------
Worklog Id: (was: 755196)
Remaining Estimate: 0h
Time Spent: 10m
> Protocol namespace not parsed correctly if protocol is defined by full name
> ---------------------------------------------------------------------------
>
> Key: AVRO-3486
> URL: https://issues.apache.org/jira/browse/AVRO-3486
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.11.1
> Reporter: Oscar Westra van Holthe - Kind
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When parsing a protocol with a full name (but no namespace), the namespace is
> not parsed correctly.
> The spec for [Protocol
> Declaration|https://avro.apache.org/docs/current/spec.html#Protocol+Declaration]
> says:
> {quote}The name and namespace qualification rules defined for schema objects
> apply to protocols as well.
> {quote}
> However, a protocol namespace can only be specified using the {{namespace}}
> attribute, not by using a full name like {{qualified.Name}} as protocol name.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
