[
https://issues.apache.org/jira/browse/AVRO-265?focusedWorklogId=755200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755200
]
ASF GitHub Bot logged work on AVRO-265:
---------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/22 12:21
Start Date: 11/Apr/22 12:21
Worklog Time Spent: 10m
Work Description: opwvhk opened a new pull request, #1638:
URL: https://github.com/apache/avro/pull/1638
This change fixes this cosmetic bug.
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-265
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR ~adds~ updates the following unit tests ~__OR__ does not need
testing for this extremely good reason~:
`reservedwords.avpr` and `unicode.avpr` (removed null namespaces from
the expected output)
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
Issue Time Tracking
-------------------
Worklog Id: (was: 755200)
Remaining Estimate: 0h
Time Spent: 10m
> Protocol namespace always written out in toJson
> -----------------------------------------------
>
> Key: AVRO-265
> URL: https://issues.apache.org/jira/browse/AVRO-265
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.2.0
> Reporter: Todd Lipcon
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The javadoc for Protocol indicates that namespaces are optional. However,
> toJson() always prints it out. If no namespace is set, it generates
> "namespace": null in the JSON.
> Not sure whether namespaces are in fact required, or if it should just not
> output it when null.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
