[ 
https://issues.apache.org/jira/browse/AVRO-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521565#comment-17521565
 ] 

ASF subversion and git services commented on AVRO-3483:
-------------------------------------------------------

Commit b67c34c13007f5248bdb041ca2ae7228d57f773e in avro's branch 
refs/heads/branch-1.11 from Martin Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=b67c34c13 ]

AVRO-3483: [Rust] Log error messages with a reason when the validation fails 
(#1636)

* AVRO-3483: [Rust] Log error messages with a reason when the validation fails

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3483: Add a failure reason for missing schema in a Union by index

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3483: Assert the error log messages after failed validation

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3483: Value::validate_internal() now returns Option<String>

Some brings the accumulated error message(s).
None means that the validation passed!

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3483: Minor cleanup

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3483: Add a test case for Value::Enum with index out of bounds

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3483: Add a test case for the validation failure when Value::Map does 
not have items for the schema fields

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3483: TestLogger is enabled only for error logs

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

* AVRO-3483: Do not allocate new Some's in accumulate function

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
(cherry picked from commit c9a346e8eb6012fdc8594877f02ea21be98c8b26)


> [Rust] Log error messages with a reason when the validation fails
> -----------------------------------------------------------------
>
>                 Key: AVRO-3483
>                 URL: https://issues.apache.org/jira/browse/AVRO-3483
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: rust
>            Reporter: Martin Tzvetanov Grigorov
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Currently types::Value::validate(Schema) just returns a boolean with the 
> result of the validation.
> It would be good if the Rust SDK logs the reason for a failed validation.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to