[ https://issues.apache.org/jira/browse/AVRO-3497?focusedWorklogId=759457&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759457 ]
ASF GitHub Bot logged work on AVRO-3497: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Apr/22 18:06 Start Date: 20/Apr/22 18:06 Worklog Time Spent: 10m Work Description: zcsizmadia commented on code in PR #1658: URL: https://github.com/apache/avro/pull/1658#discussion_r854416689 ########## lang/csharp/src/apache/test/Generic/GenericEnumTests.cs: ########## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +using Avro.Generic; +using NUnit.Framework; + +namespace Avro.test.Generic +{ + [TestFixture] + public class GenericEnumTests + { + private const string baseSchema = "{\"type\": \"enum\", \"name\": \"Test\", \"symbols\": " + + "[\"Unknown\", \"A\", \"B\"], \"default\": \"Unknown\" }"; + + [Test] + public void TestEquals() + { + GenericEnum genericEnum = GetBaseGenericEnum(); + GenericEnum genericEnum2 = GetBaseGenericEnum(); + + Assert.IsTrue(genericEnum.Equals(genericEnum2)); + } + + [Test] + public void TestEqualsNotEqual() + { + GenericEnum genericEnum = GetBaseGenericEnum(); + GenericEnum genericEnum2 = new GenericEnum(Schema.Parse(baseSchema) as EnumSchema, "B"); + + Assert.IsFalse(genericEnum.Equals(genericEnum2)); + } + + [Test] + public void TestEqualsObject() + { + GenericEnum genericEnum = GetBaseGenericEnum(); + object genericEnum2 = genericEnum; + + Assert.IsTrue(genericEnum.Equals(genericEnum2)); + } + + [Test] + public void TestEqualsObjectNotEqual() + { + GenericEnum genericEnum = GetBaseGenericEnum(); + GenericEnum genericEnum2 = new GenericEnum(Schema.Parse(baseSchema) as EnumSchema, "B"); + + Assert.IsFalse(genericEnum.Equals((object)genericEnum2)); Review Comment: Can the casting be removed and fix the CodeQL warnings? Issue Time Tracking ------------------- Worklog Id: (was: 759457) Time Spent: 2h 10m (was: 2h) > Fix IDE0075 Simplify conditional expression > ------------------------------------------- > > Key: AVRO-3497 > URL: https://issues.apache.org/jira/browse/AVRO-3497 > Project: Apache Avro > Issue Type: Sub-task > Components: csharp > Reporter: Kyle Schoonover > Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > {code:java} > // dotnet_style_prefer_simplified_boolean_expressions = true > var result1 = M1() && M2(); > var result2 = M1() || M2(); > // dotnet_style_prefer_simplified_boolean_expressions = false > var result1 = M1() && M2() ? true : false; > var result2 = M1() ? true : M2(); {code} -- This message was sent by Atlassian Jira (v8.20.7#820007)