[
https://issues.apache.org/jira/browse/AVRO-3503?focusedWorklogId=760437&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760437
]
ASF GitHub Bot logged work on AVRO-3503:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 21:17
Start Date: 21/Apr/22 21:17
Worklog Time Spent: 10m
Work Description: KyleSchoonover opened a new pull request, #1666:
URL: https://github.com/apache/avro/pull/1666
### Jira
- [ ] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them
in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3503
### Tests
- [ ] My PR adds the following unit tests: Adding coverage for Equals changes
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
Issue Time Tracking
-------------------
Worklog Id: (was: 760437)
Remaining Estimate: 0h
Time Spent: 10m
> C# Equals should not apply 'is' or 'as'
> ---------------------------------------
>
> Key: AVRO-3503
> URL: https://issues.apache.org/jira/browse/AVRO-3503
> Project: Apache Avro
> Issue Type: Bug
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> References:
> [Equals should not apply “is” — CodeQL query help documentation
> (github.com)|https://codeql.github.com/codeql-query-help/csharp/cs-equals-uses-is/]
> [Equals should not apply “as” — CodeQL query help documentation
> (github.com)|https://codeql.github.com/codeql-query-help/csharp/cs-equals-uses-as/]
>
> This will not allow equals methods to work correctly when dealing with
> inheritance.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
