[
https://issues.apache.org/jira/browse/AVRO-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555481#comment-17555481
]
Christophe Le Saec commented on AVRO-2160:
------------------------------------------
Yes, common json usage is without schema, so it can't behave same as Avro; but
[swagger allows default
value|https://swagger.io/blog/api-development/unlocking-the-spec-the-default-keyword/].
The linked PR is to allow that, for a field defined as
{code:json}
{"name":"lastname","type":["string","null"],"default":"last"}
{code}
{"lastname": null} and {}
won't have same meaning, lastname will be "last" for second example, which is
the definition of default (and this also work for binary format).
The only thing this PR won't do is using default value for writing. When you
have an indexed record with a field value that matches the default value, you
can't know if in source, value was missing or if it was equals to the default;
so, writing will explicitly write the value.
> Json to Avro with non required value and union schema failing
> -------------------------------------------------------------
>
> Key: AVRO-2160
> URL: https://issues.apache.org/jira/browse/AVRO-2160
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.8.2
> Reporter: Lydie
> Priority: Critical
> Labels: java, pull-request-available
>
> I am trying to convert this string:
> str str4
> using this schema:
> {"type":"record",
> "namespace":"foo","name":"Person","fields":[\\{"name":"lastname","type":
> ["null","string"], "default":null}
> ,\{"name":"firstname","type":"string"},{"name":"age","type":["null","int"],
> "default":null}]}
> I get this error
> {color:#ff0000}com.syapse.messagePublisher.publisher.AvroEncodeException:
> Expected field name not found:
> lastnamein\{"firstname":"John","age":{"int":35}}{color}at
> com.syapse.messagePublisher.publisher.AvroEncoder.convertJsonToAvro(AvroEncoder.java:78)
>
> Although this should give me the correct syntax for a non required filed.
> Note that it works for
> {"lastname":\\{"string" : "Doe"}
> ,"firstname":"John","age":\{"int":36}}
>
> What am I missing ( using Abro 1.8.2)
> here is my code:
>
> {code:java}
> public static byte[] convertJsonToAvro(byte[] data, String schemaStr) throws
> AvroEncodeException {
> InputStream input = null;
> DataFileWriter<GenericRecord> writer = null;
> ByteArrayOutputStream output = null;
> try {
> Schema schema = new Schema.Parser().parse(schemaStr);
> DatumReader<GenericRecord> reader = new
> GenericDatumReader<GenericRecord>(schema);
> input = new ByteArrayInputStream(data);
> DataInputStream din = new DataInputStream(input);
> output = new ByteArrayOutputStream();
> writer = new DataFileWriter<GenericRecord>(new
> GenericDatumWriter<GenericRecord>());
> writer.create(schema, output);
> Decoder decoder = DecoderFactory.get().jsonDecoder(schema, din);
> GenericRecord datum = null;
> while (true) {
> try {
> datum = reader.read(null, decoder);
> } catch (EOFException eofe) {
> break;
> }
> writer.append(datum);
> }
> writer.flush();
> writer.close();
> return output.toByteArray();
> } catch (AvroTypeException e) {
> throw new AvroEncodeException(e.getMessage() + "in" + new String(data));
> } catch (IOException e1) {
> throw new AvroEncodeException("Error decoding Json " + e1.getMessage());
> } finally {
> try {
> input.close();
> } catch (Exception e) {
> }
> }
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
