[ https://issues.apache.org/jira/browse/AVRO-3547?focusedWorklogId=785036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-785036 ]
ASF GitHub Bot logged work on AVRO-3547: ---------------------------------------- Author: ASF GitHub Bot Created on: 27/Jun/22 11:08 Start Date: 27/Jun/22 11:08 Worklog Time Spent: 10m Work Description: KalleOlaviNiemitalo commented on code in PR #1736: URL: https://github.com/apache/avro/pull/1736#discussion_r907262754 ########## lang/c++/impl/NodeImpl.cc: ########## @@ -274,6 +286,9 @@ void NodeRecord::printJson(std::ostream &os, size_t depth) const { depth); } } + if(customAttributes_.size() == fields) { + printCustomFields(customAttributes_.get(i), depth, os); + } os << '\n'; Review Comment: No, that would just add a flush, which is not necessary here. <https://en.cppreference.com/w/cpp/io/manip/endl> Issue Time Tracking ------------------- Worklog Id: (was: 785036) Time Spent: 1h (was: 50m) > support custom attribute at field level > --------------------------------------- > > Key: AVRO-3547 > URL: https://issues.apache.org/jira/browse/AVRO-3547 > Project: Apache Avro > Issue Type: Improvement > Components: c++ > Reporter: Nilesh Yadav > Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Custom attributes are allowed at field level as per Avro specification : > [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1] > > But Avro c++ implementation does not support custom attribute at field level. > e.g. following schema cannot be parsed correctly due to presence of "sqlName" > attribute. > { > 'doc': 'weather warning', > 'name': 'weather', > 'type': 'record', > 'fields': [ > { > 'name': 'station', > 'type':'string', > 'sqlName':'abc-@12' > }, > { > 'name': 'time', > 'type':'long', > 'sqlName': '用户名' > }] > } > Update implementation to support custom attribute at field level. -- This message was sent by Atlassian Jira (v8.20.7#820007)