[
https://issues.apache.org/jira/browse/AVRO-3219?focusedWorklogId=788193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-788193
]
ASF GitHub Bot logged work on AVRO-3219:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/22 11:44
Start Date: 06/Jul/22 11:44
Worklog Time Spent: 10m
Work Description: KalleOlaviNiemitalo commented on code in PR #1348:
URL: https://github.com/apache/avro/pull/1348#discussion_r914741460
##########
lang/csharp/src/apache/main/Reflect/ClassCache.cs:
##########
@@ -269,18 +269,12 @@ public void LoadClassCache(Type objType, Schema s)
LoadClassCache(objType, o);
}
- if (objType.IsGenericType)
+ var innerType =
Nullable.GetUnderlyingType(objType);
+ if (innerType != null)
Review Comment:
Did you intentionally remove the `innerType.IsEnum` check?
Issue Time Tracking
-------------------
Worklog Id: (was: 788193)
Time Spent: 1h 50m (was: 1h 40m)
> Not support for nullable enum type fields
> -----------------------------------------
>
> Key: AVRO-3219
> URL: https://issues.apache.org/jira/browse/AVRO-3219
> Project: Apache Avro
> Issue Type: New Feature
> Components: csharp
> Affects Versions: 1.10.2
> Reporter: Zike Yang
> Assignee: Zike Yang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.1
>
> Attachments: AVRO-3219.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently, when the schema contain nullable enum type, it will throw
> Exception`Couldnot find enumeration for avro full name ...` while writing or
> reading.
>
> We need to add support for the nullable enum type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
