[ 
https://issues.apache.org/jira/browse/AVRO-3571?focusedWorklogId=793572&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793572
 ]

ASF GitHub Bot logged work on AVRO-3571:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jul/22 07:43
            Start Date: 21/Jul/22 07:43
    Worklog Time Spent: 10m 
      Work Description: martin-g commented on code in PR #1756:
URL: https://github.com/apache/avro/pull/1756#discussion_r926356921


##########
lang/py/avro/schema.py:
##########
@@ -51,7 +51,15 @@
 
 import avro.constants

Review Comment:
   Should this be removed ?
   CodeQL says that `avro.constants` is imported twice





Issue Time Tracking
-------------------

    Worklog Id:     (was: 793572)
    Time Spent: 2h  (was: 1h 50m)

> Python code refactor and rearrangement
> --------------------------------------
>
>                 Key: AVRO-3571
>                 URL: https://issues.apache.org/jira/browse/AVRO-3571
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: python
>            Reporter: Diptonil Roy
>            Priority: Minor
>              Labels: beginner, easyfix, newbie, pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> The changes made are:
>  # Code altered according to PEP 8 conventions. Files changed are: io.py, 
> constants.py, schema.py, codecs.py, datafile.py and compatibility.py.
>  # General constants INT_MIN_VALUE, INT_MAX_VALUE, LONG_MIN_VALUE & 
> LONG_MAX_VALUE shifted from schema.py to constants.py for clarity and better 
> organization.
> (This is my first attempt to contribute to any open source project, not only 
> this project. If I have made any errors or have misunderstood any step, 
> please forgive me. I would be happy to adhere to any suggestions)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to