[
https://issues.apache.org/jira/browse/AVRO-3547?focusedWorklogId=799925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799925
]
ASF GitHub Bot logged work on AVRO-3547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/22 09:03
Start Date: 11/Aug/22 09:03
Worklog Time Spent: 10m
Work Description: thiru-mg commented on PR #1736:
URL: https://github.com/apache/avro/pull/1736#issuecomment-1211724801
I'm sorry I didn't look at the PR before. I think the approach taken here
exposes the `json` namespace as part of public API. Any future changes
hereafter will have to be backwards compatible. When I originally designed the
`json` support I took several decisions freely because it was private. Now in
one stroke the whole thing opens up for the public.
Even though support for custom-fields is indeed a welcome enhancement, the
side effect of exposing json is much bigger decision. I recommend we revert
this change and reintroduce it without exposing json or after a complete review
of the JSON.
Again, I'm sorry I failed to notice it early enough.
Issue Time Tracking
-------------------
Worklog Id: (was: 799925)
Time Spent: 5h (was: 4h 50m)
> support custom attribute at field level
> ---------------------------------------
>
> Key: AVRO-3547
> URL: https://issues.apache.org/jira/browse/AVRO-3547
> Project: Apache Avro
> Issue Type: Improvement
> Components: c++
> Reporter: Nilesh Yadav
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Custom attributes are allowed at field level as per Avro specification :
> [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
>
> But Avro c++ implementation does not support custom attribute at field level.
> e.g. following schema cannot be parsed correctly due to presence of "sqlName"
> attribute.
> {
> 'doc': 'weather warning',
> 'name': 'weather',
> 'type': 'record',
> 'fields': [
> {
> 'name': 'station',
> 'type':'string',
> 'sqlName':'abc-@12'
> },
> {
> 'name': 'time',
> 'type':'long',
> 'sqlName': '用户名'
> }]
> }
> Update implementation to support custom attribute at field level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
