[ https://issues.apache.org/jira/browse/AVRO-3616?focusedWorklogId=802928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802928 ]
ASF GitHub Bot logged work on AVRO-3616: ---------------------------------------- Author: ASF GitHub Bot Created on: 23/Aug/22 15:32 Start Date: 23/Aug/22 15:32 Worklog Time Spent: 10m Work Description: KalleOlaviNiemitalo commented on code in PR #1836: URL: https://github.com/apache/avro/pull/1836#discussion_r952780342 ########## lang/c++/impl/ValidSchema.cc: ########## @@ -70,7 +70,7 @@ static bool validate(const NodePtr &node, SymbolMap &symbolMap) { node->lock(); auto leaves = node->leaves(); - for (auto i = 0; i < leaves; ++i) { + for (long unsigned int i = 0; i < leaves; ++i) { Review Comment: On 64-bit Microsoft Windows, `size_t` is 64-bit, but `long unsigned int` is 32-bit and would not be pedantically correct. In practice though, it's rather unlikely that a node would have billions of leaves. Issue Time Tracking ------------------- Worklog Id: (was: 802928) Time Spent: 0.5h (was: 20m) > [C++]: Fix compilation warnings > ------------------------------- > > Key: AVRO-3616 > URL: https://issues.apache.org/jira/browse/AVRO-3616 > Project: Apache Avro > Issue Type: Improvement > Components: c++ > Affects Versions: 1.11.1 > Reporter: Martin Tzvetanov Grigorov > Assignee: Martin Tzvetanov Grigorov > Priority: Minor > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Building the C++ SDK prints two types of warnings: > > 1. Usage of deprecated Boost test related import > {code:java} > In file included from /usr/include/boost/config/header_deprecated.hpp:18, > from /usr/include/boost/test/included/unit_test_framework.hpp:12, > from /home/runner/work/avro/avro/lang/c++/test/SpecificTests.cc:19: > > /usr/include/boost/test/included/unit_test_framework.hpp:13:1: note: > #pragma message: This header is deprecated. Use This header is deprecated. > Please use <boost/test/included/unit_test.hpp> instead. instead. > 13 | BOOST_HEADER_DEPRECATED( "This header is deprecated. Please use > <boost/test/included/unit_test.hpp> instead." ) > | ^~~~~~~~~~~~~~~~~~~~~~~{code} > 2. Wrong order of constructor arguments > {code:java} > In file included from > /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh: > In constructor ‘avro::DataFileReaderBase::DataFileReaderBase(const > char*)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: > warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after > [-Wreorder] 200 | Codec codec_; | > ^~~~~~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning: > ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder] 197 | > const DecoderPtr decoder_; | > ^~~~~~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:262:1: > warning: when initialized here [-Wreorder] 262 | > DataFileReaderBase::DataFileReaderBase(const char *filename) : > filename_(filename), stream_(fileSeekableInputStream(filename)), > codec_(NULL_CODEC), | ^~~~~~~~~~~~~~~~~~In file included from > /home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:19:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh: > In constructor > ‘avro::DataFileReaderBase::DataFileReaderBase(std::unique_ptr<avro::InputStream>)’:/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:200:11: > warning: ‘avro::DataFileReaderBase::codec_’ will be initialized after > [-Wreorder] 200 | Codec codec_; | > ^~~~~~/home/martin/git/apache/avro/lang/c++/api/DataFile.hh:197:22: warning: > ‘const DecoderPtr avro::DataFileReaderBase::decoder_’ [-Wreorder] 197 | > const DecoderPtr decoder_; | > ^~~~~~~~/home/martin/git/apache/avro/lang/c++/impl/DataFile.cc:268:1: > warning: when initialized here [-Wreorder] 268 | > DataFileReaderBase::DataFileReaderBase(std::unique_ptr<InputStream> > inputStream) : stream_(std::move(inputStream)), codec_(NULL_CODEC), {code} > Full example could be seen at > https://github.com/apache/avro/runs/7959849252?check_suite_focus=true -- This message was sent by Atlassian Jira (v8.20.10#820010)