[ https://issues.apache.org/jira/browse/AVRO-3622?focusedWorklogId=804892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-804892 ]
ASF GitHub Bot logged work on AVRO-3622: ---------------------------------------- Author: ASF GitHub Bot Created on: 30/Aug/22 14:26 Start Date: 30/Aug/22 14:26 Worklog Time Spent: 10m Work Description: perj commented on code in PR #1843: URL: https://github.com/apache/avro/pull/1843#discussion_r958554420 ########## lang/py/avro/test/test_compatibility.py: ########## @@ -659,6 +688,7 @@ def test_schema_compatibility(self): ENUM_ABC_FIELD_DEFAULT_B_ENUM_DEFAULT_A_RECORD, ), (NS_RECORD1, NS_RECORD2), + (WITHOUT_NAMESPACE_RECORD, WITH_NAMESPACE_RECORD), Review Comment: Thanks for explaining, it does look like this is per the spec then. Issue Time Tracking ------------------- Worklog Id: (was: 804892) Time Spent: 1h 10m (was: 1h) > Python compatibility check fails if record with and without namespace are > compared > ---------------------------------------------------------------------------------- > > Key: AVRO-3622 > URL: https://issues.apache.org/jira/browse/AVRO-3622 > Project: Apache Avro > Issue Type: Bug > Components: python > Affects Versions: 1.11.1 > Reporter: Jarkko Jaakola > Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Avro spec: > {noformat} > To match, one of the following must hold: > ... > * both schemas are records with the same (unqualified) name{noformat} > Following records are compatible. The `ReaderWriterCompatibilityChecker` > reports name mismatch and an incompatibility. Similar test case with Java > implementation passes. > {code:java} > WITHOUT_NAMESPACE_RECORD = parse( > json.dumps( > { > "type": SchemaType.RECORD, > "name": "Record1", > "fields": [ > { > "name": "f1", > "type": "int", > } > ], > }, > ) > ) > WITH_NAMESPACE_RECORD = parse( > json.dumps( > { > "type": SchemaType.RECORD, > "name": "ns.Record1", > "fields": [ > { > "name": "f1", > "type": "int", > } > ], > }, > ) > ) > > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)