[ 
https://issues.apache.org/jira/browse/AVRO-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598230#comment-17598230
 ] 

Christophe Le Saec commented on AVRO-3597:
------------------------------------------

Attached PR should fix the issue.

> Recent changes in GenericDatumReader.java break compatibility
> -------------------------------------------------------------
>
>                 Key: AVRO-3597
>                 URL: https://issues.apache.org/jira/browse/AVRO-3597
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.11.1
>            Reporter: Viktor Dvoretskii
>            Assignee: Christophe Le Saec
>            Priority: Major
>
> We use a custom SpecificDatumReader which overrides the string creation 
> logic. It looks like this:
> {code:java}
> class CustomSpecificDatumReader<T> extends SpecificDatumReader<T> {
>     @Override
>     protected Object newInstanceFromString(Class c, String s) {
>         // custom logic
>     }
> } {code}
> With [this 
> commit|https://github.com/apache/avro/commit/820ed6e5ea4417b5735078bfd26c99f1305ea363],
>  the newInstanceFromString() method is no longer called. Instead, strings are 
> created with the hard-coded logic within GenericDatumReader.ReaderCache.
> It would be appreciated if you made it possible to override the string 
> creation logic used by GenericDatumReader.ReaderCache. Preferably make use of 
> the newInstanceFromString() method again to maintain backward compatibility.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to