TomBruns opened a new pull request, #2741: URL: https://github.com/apache/avro/pull/2741
[AVRO-2825](https://issues.apache.org/jira/browse/AVRO-2825?jql=text%20~%20%22csharp%20logical%22) ## What is the purpose of the change - This pull request resolves an outstanding issue with the csharp implementation behavior that is **not consistent** with the AVRO spec and the java behavior. - Per the AVRO Spec: - *Language implementations must ignore unknown logical types when reading, and should use the underlying Avro type* - The current csharp implementation throws an exception for unrecognized Logical Types. **NOTE: This PR WILL change the behavior of the current nuget package. It corrects it to align with the AVRO spec.** ## Verifying this change This change is already covered by existing tests: - test > AvroGen > AvroGenSchemaTests.cs > NotSupportedSchema - corrected expected result of Test - test > Schema > SchemaTests.cs > TestUnknownLogical - corrected expected result of Test This change added tests and can be verified as follows: - test > Util > LogicalTypeTests.cs > TestUnknownLogicalType - added more complex test to confirm underlying AVRO base type is used. ## Documentation - Does this pull request introduce a new feature? (no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
