hexagonhill opened a new pull request, #3166:
URL: https://github.com/apache/avro/pull/3166
Example of changed code to remove error.
`int32_t checksum = crc();`
to
`auto checksum = crc();`
`error: conversion from ‘boost::crc_optimal<32, 79764919, 4294967295,
4294967295, true, true>::value_type’ {aka ‘long unsigned int’} to ‘uint32_t’
{aka ‘unsigned int’} may change value [-Werror=conversion]`
Further errors not related to avro cmake but using a meson build port was
missing <algorithm> header in some files such that std::find and std::find_if
could not be found. Thought to include them in PR.
These changes passed ./build.sh test
Thanks for the code!
Sorry for the informal request a bit busy but wanted to give back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
