here-abarany opened a new pull request, #3435:
URL: https://github.com/apache/avro/pull/3435
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you
want to help us improve Avro. To help the community review your contribution in
the best possible way, please go through the checklist below, which will get
the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the
pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers
faster: either the language ("java", "python") or subsystem such as "build" or
"doc" are good candidates.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the
entire project](https://github.com/apache/avro/blob/main/BUILD.md) or just the
[language-specific
SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Every commit message references Jira issues in their subject lines. In
addition, commits follow the guidelines from [How to write a good git commit
message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue
reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
This allows for only the static or shared library to be built if only one of
them is needed, avoiding the duplicate compilations and avoiding installing
unwanted libraries. The standard CMake variable `BUILD_SHARED_LIBS` is also
respected when explicitly set, enabling only the corresponding shared/static
library, allowing the build to interface cleaner with standard build scripts
built on CMake.
The `AVRO_BUILD_SHARED` CMake variable may now be set to `OFF` to disable
building of the shared library, and `AVRO_BUILD_STATIC` may be set to `OFF` to
disable building of the static library. The default values of these variables
respect the value of `BUILD_SHARED_LIBS`:
* If `BUILD_SHARED_LIBS` is unset, shared and static are both enabled with
the same behavior as before.
* If `BUILD_SHARED_LIBS` is `ON`, only the shared library is enabled.
* If `BUILD_SHARED_LIBS` is `OFF`, only the static library is enabled.
The tests and executables will link against the shared library if the static
library is disabled.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage. I
manually checked all three permutations of the default static and shared,
static only, and shared only.
## Documentation
CMake build options do not appear to be documented, so no documentation has
been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
