tyler-blip opened a new pull request, #3466: URL: https://github.com/apache/avro/pull/3466
<!-- ## What is the purpose of the change *(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)* ## Verifying this change *(Please pick one of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Extended interop tests to verify consistent valid schema names between SDKs* - *Added test that validates that Java throws an AvroRuntimeException on invalid binary data* - *Manually verified the change by building the website and checking the new redirect* ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) --> ## What is the purpose of the change This pull request fixes a namespace inheritance bug in the JavaScript Avro library where shared mutable state was causing namespace corruption when parsing nested schemas with mixed namespace declarations, fixing AVRO-4173. The issue occurred when parsing nested types where some inherit namespaces from their parent while others have explicit namespaces. The shared `opts` object was being modified in place, causing namespace context corruption for later type references. ## Verifying this change This change added tests and can be verified as follows: - *Added `namespace inheritance` test that demonstrates the core bug fix - validates that type references resolve to correct namespaces when nested types have mixed namespace inheritance* - *Added `deep namespace inheritance` test that validates the fix works across multiple levels of nesting with various namespace changes* - *Both new tests fail without the fix and pass with it, proving the fix's effectiveness* - *All existing tests continue to pass (383 passing)* - *Manually verified by testing schema parsing with various namespace inheritance scenarios* ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
