[ 
https://issues.apache.org/jira/browse/BAHIR-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601868#comment-15601868
 ] 

ASF GitHub Bot commented on BAHIR-72:
-------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/bahir-flink/pull/7#discussion_r84674575
  
    --- Diff: flink-connector-netty/pom.xml ---
    @@ -0,0 +1,87 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  ~ Licensed to the Apache Software Foundation (ASF) under one or more
    +  ~ contributor license agreements.  See the NOTICE file distributed with
    +  ~ this work for additional information regarding copyright ownership.
    +  ~ The ASF licenses this file to You under the Apache License, Version 2.0
    +  ~ (the "License"); you may not use this file except in compliance with
    +  ~ the License.  You may obtain a copy of the License at
    +  ~
    +  ~    http://www.apache.org/licenses/LICENSE-2.0
    +  ~
    +  ~ Unless required by applicable law or agreed to in writing, software
    +  ~ distributed under the License is distributed on an "AS IS" BASIS,
    +  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +  ~ See the License for the specific language governing permissions and
    +  ~ limitations under the License.
    +  -->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <groupId>org.apache.bahir</groupId>
    +    <artifactId>bahir-flink_parent_2.11</artifactId>
    +    <version>1.0.0-SNAPSHOT</version>
    +    <relativePath>..</relativePath>
    +  </parent>
    +
    +  <artifactId>flink-connector-netty_2.11</artifactId>
    +  <name>flink-connector-netty</name>
    +  <version>1.0.0-SNAPSHOT</version>
    +  <packaging>jar</packaging>
    +
    +  <dependencies>
    +    <dependency>
    +      <groupId>io.netty</groupId>
    +      <artifactId>netty-all</artifactId>
    +      <version>4.1.5.Final</version>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.apache.flink</groupId>
    +      <artifactId>flink-table_${scala.binary.version}</artifactId>
    +      <version>${flink.version}</version>
    +    </dependency>
    --- End diff --
    
    I don't think its a good idea to add the Table API here as a dependency 
just for one connector example.
    
    Flink Table could grow quite big in the future, and users of the connector 
will not execute a single line of the table API.


> support netty: pushed tcp/http connector
> ----------------------------------------
>
>                 Key: BAHIR-72
>                 URL: https://issues.apache.org/jira/browse/BAHIR-72
>             Project: Bahir
>          Issue Type: New Feature
>          Components: Flink Streaming Connectors
>            Reporter: shijinkui
>
> Also discuss from flink: https://issues.apache.org/jira/browse/FLINK-4630
> When source stream get start, listen a provided tcp port, receive stream data 
> from user data source.
> This netty tcp source is keepping alive and end-to-end, that is from business 
> system to flink worker directly. 
> Such source service is needed in produce indeed.
> describe the source in detail below:
> 1.    source run as a netty tcp and http server
> 2.    user provide a tcp port, if the port is in used, increace the port 
> number between 1024 to 65535. Source can parallel.
> 3.    callback the provided url to report the real port to listen
> 4.    user push streaming data to netty server, then collect the data to flink



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to