[ 
https://issues.apache.org/jira/browse/BAHIR-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081738#comment-16081738
 ] 

ASF GitHub Bot commented on BAHIR-100:
--------------------------------------

Github user davidrosenstark commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/47#discussion_r126603788
  
    --- Diff: 
streaming-mqtt/src/main/scala/org/apache/spark/streaming/mqtt/MQTTPairedByteArrayInputDStream.scala
 ---
    @@ -0,0 +1,143 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.streaming.mqtt
    +
    +import org.eclipse.paho.client.mqttv3._
    +import org.eclipse.paho.client.mqttv3.persist.MemoryPersistence
    +
    +import org.apache.spark.storage.StorageLevel
    +import org.apache.spark.streaming.StreamingContext
    +import org.apache.spark.streaming.dstream._
    +import org.apache.spark.streaming.receiver.Receiver
    +
    +/**
    + * Input stream that subscribe messages from a Mqtt Broker.
    + * Uses eclipse paho as MqttClient http://www.eclipse.org/paho/
    + * @param brokerUrl          Url of remote mqtt publisher
    --- End diff --
    
    this was missing in all three classes. adding to all 3


> Providing MQTT Spark Streaming to return encoded Byte[] message without 
> corruption
> ----------------------------------------------------------------------------------
>
>                 Key: BAHIR-100
>                 URL: https://issues.apache.org/jira/browse/BAHIR-100
>             Project: Bahir
>          Issue Type: New Feature
>          Components: Spark Streaming Connectors
>            Reporter: Anntinu Josy
>            Assignee: Anntinu Josy
>              Labels: mqtt, spark, streaming
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Now a days Network bandwidth is becoming a serious resource that need to be 
> conserver in IoT ecosystem, For this puropse we are using different byte[] 
> based encoding such as Protocol Buffer and flat Buffer, Once this encoded 
> message is converted into string the data becomes corrupted, So same byte[] 
> format need to be preserved when forwarded.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to