[
https://issues.apache.org/jira/browse/BAHIR-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181425#comment-16181425
]
ASF GitHub Bot commented on BAHIR-123:
--------------------------------------
GitHub user emlaver opened a pull request:
https://github.com/apache/bahir/pull/50
[BAHIR-123] Support latest version of play-json for sql-cloudant
Updated play json dependency
- Added additional dependencies that used to exist but were removed in
latest version
- Fixed json import and calls using latest methods in play-json library
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emlaver/bahir use-latest-play-json
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit fb7ee928125caa03d32c59f710825908849678cc
Author: Esteban Laver <[email protected]>
Date: 2017-08-04T17:50:32Z
Updated play json dependency
- Added additional dependencies that used to exist but were removed in
latest version
- Fixed json import and calls using latest methods in play-json library
----
> Fix errors to support the latest version of Play JSON library for sql-cloudant
> ------------------------------------------------------------------------------
>
> Key: BAHIR-123
> URL: https://issues.apache.org/jira/browse/BAHIR-123
> Project: Bahir
> Issue Type: Task
> Reporter: Esteban Laver
> Assignee: Esteban Laver
> Priority: Minor
>
> The latest version is 2.6.2. Error during mvn install -pl sql-cloudant after
> updating play-json to 2.6.2 in sql-cloudant/pom.xml:
> [ERROR]
> /Users/estebanmlaver/emlaver-bahir/sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreConfigManager.scala:19:
> object typesafe is not a member of package com
> [ERROR] import com.typesafe.config.ConfigFactory
> [ERROR] ^
> [ERROR]
> /Users/estebanmlaver/emlaver-bahir/sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreConfigManager.scala:52:
> not found: value ConfigFactory
> [ERROR] private val configFactory = ConfigFactory.load()
> [ERROR] ^
> [ERROR] two errors found
> Maven compile dependencies need to be added to pom.xml that existed in
> play-json 2.5.9 but were removed in 2.6.2.
> Additional info. from Patrick Titzler between play-json versions 2.5.x and
> 2.6.x:
> Looks like the parameter data type has been changed from `Seq[JsValue]`
> (https://www.playframework.com/documentation/2.5.x/api/scala/index.html#play.api.libs.json.JsArray)
> to `IndexedSeq[JsValue]`
> https://playframework.com/documentation/2.6.x/api/scala/index.html#play.api.libs.json.JsArray
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
