[
https://issues.apache.org/jira/browse/BAHIR-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311319#comment-16311319
]
ASF GitHub Bot commented on BAHIR-137:
--------------------------------------
Github user ricellis commented on a diff in the pull request:
https://github.com/apache/bahir/pull/60#discussion_r159649060
--- Diff:
sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala
---
@@ -72,6 +72,7 @@ class ChangesReceiver(config: CloudantChangesConfig)
val status = headers.getOrElse("Status", IndexedSeq.empty)
val errorMsg = "Error retrieving _changes feed " +
config.getDbname + ": " + status(0)
reportError(errorMsg, new CloudantException(errorMsg))
+ stop(errorMsg)
--- End diff --
Does this call to `stop` result in the errorMsg being reported twice?
> Load performance improvements for _changes API in sql-cloudant
> --------------------------------------------------------------
>
> Key: BAHIR-137
> URL: https://issues.apache.org/jira/browse/BAHIR-137
> Project: Bahir
> Issue Type: Improvement
> Affects Versions: Spark-2.2.0
> Reporter: Esteban Laver
> Assignee: Esteban Laver
>
> Items for improving _changes feed load:
> - Make Spark streaming batch interval visible to the user for tuning based on
> type/size of document and number of docs in database
> - Merge BAHIR-128: Improve stability of _changes receiver
> - Merge BAHIR-154: refactor sql-cloudant to use java-cloudant library
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
