[
https://issues.apache.org/jira/browse/BAHIR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313235#comment-16313235
]
ASF GitHub Bot commented on BAHIR-154:
--------------------------------------
Github user ricellis commented on a diff in the pull request:
https://github.com/apache/bahir/pull/61#discussion_r159889542
--- Diff:
sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/JsonStoreRDD.scala
---
@@ -101,24 +105,24 @@ class JsonStoreRDD(sc: SparkContext, config:
CloudantConfig)
case LessThanOrEqual(attr, v) => ("$lte", v)
case _ => (null, null)
}
- val convertedV: JsValue = {
+ val convertedV: JsonElement = {
// TODO Better handing of other types
if (value != null) {
value match {
- case s: String => Json.toJson(s)
- case l: Long => Json.toJson(l)
- case d: Double => Json.toJson(d)
- case i: Int => Json.toJson(i)
- case b: Boolean => Json.toJson(b)
- case t: java.sql.Timestamp => Json.toJson(t)
+ case s: String => parser.parse(s)// Json.toJson(s)
--- End diff --
some old code here that should probably be removed (and on the following
line)
> Refactor sql-cloudant to use Cloudant's java-cloudant features
> --------------------------------------------------------------
>
> Key: BAHIR-154
> URL: https://issues.apache.org/jira/browse/BAHIR-154
> Project: Bahir
> Issue Type: Improvement
> Affects Versions: Spark-2.2.0
> Reporter: Esteban Laver
> Assignee: Esteban Laver
>
> Cloudant's java-cloudant library (which is currently used for testing)
> contains several features that sql-cloudant can benefit from:
> - HTTP 429 backoff
> - View builder API to potentially simplify loading for _all_docs/views
> - Improved exception handling when executing HTTP requests
> - Future support for IAM API key
> Would need to replace current scala HTTP library with OkHttp library, and
> also replace play-json with GSON library.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
