[
https://issues.apache.org/jira/browse/BAHIR-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750387#comment-16750387
]
ASF GitHub Bot commented on BAHIR-107:
--------------------------------------
Github user lukasz-antoniak commented on a diff in the pull request:
https://github.com/apache/bahir/pull/76#discussion_r250347037
--- Diff: dev/release-build.sh ---
@@ -231,83 +229,92 @@ function checkout_code {
git_hash=`git rev-parse --short HEAD`
echo "Checked out Bahir git hash $git_hash"
- cd "$BASE_DIR" #return to base dir
+ cd "$BASE_DIR" # return to base dir
}
if [[ "$RELEASE_PREPARE" == "true" ]]; then
echo "Preparing release $RELEASE_VERSION"
- # Checkout code
+ # checkout code
checkout_code
cd target/bahir
- # Build and prepare the release
- $MVN $PUBLISH_PROFILES release:clean release:prepare $DRY_RUN
-Darguments="-Dgpg.passphrase=\"$GPG_PASSPHRASE\" -DskipTests"
-DreleaseVersion="$RELEASE_VERSION" -DdevelopmentVersion="$DEVELOPMENT_VERSION"
-Dtag="$RELEASE_TAG"
+ # test with scala 2.11 and 2.12
+ ./dev/change-scala-version.sh 2.11
+ $MVN $PUBLISH_PROFILES clean test -Dscala-2.11 || exit 1
+ ./dev/change-scala-version.sh 2.12
+ $MVN $PUBLISH_PROFILES clean test || exit 1
+
+ # build and prepare the release
+ $MVN $PUBLISH_PROFILES release:clean release:prepare $DRY_RUN \
+ -DskipTests=true -Dgpg.passphrase="$GPG_PASSPHRASE" \
+ -DreleaseVersion="$RELEASE_VERSION"
-DdevelopmentVersion="$DEVELOPMENT_VERSION" -Dtag="$RELEASE_TAG"
- cd .. #exit bahir
+ cd .. # exit bahir
if [ -z "$DRY_RUN" ]; then
cd "$BASE_DIR/target/bahir"
git checkout $RELEASE_TAG
git clean -d -f -x
- $MVN $PUBLISH_PROFILES clean install -DskiptTests
-Darguments="-DskipTests"
+ $MVN $PUBLISH_PROFILES clean install -DskipTests=true
--- End diff --
`-DskipTests` does not require arguments, but Scala tests do not honour it,
see: https://github.com/scalatest/scalatest/issues/466. On my machine, while
running commands from original version of release script, tests are were being
executed.
> Build and test Bahir against Scala 2.12
> ---------------------------------------
>
> Key: BAHIR-107
> URL: https://issues.apache.org/jira/browse/BAHIR-107
> Project: Bahir
> Issue Type: Improvement
> Reporter: Ted Yu
> Priority: Major
>
> Spark has started effort for accommodating Scala 2.12
> See SPARK-14220 .
> This JIRA is to track requirements for building Bahir on Scala 2.12.7
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
