Continuing a discussion <https://github.com/apache/beam/pull/1830> Dan, Kenn, and I were having here since the bug is closed. They pointed out three things:
- Where the private constructor gets placed in the class - Where the code samples of how to use the class get placed (in the Transform versus in the static method) - Are transform classes public or private I noted that those were inconsistent in the code. When I write a new transform, I use one of the already written transforms as the basis. Looking at Combine and Count: - The private constructor is at the top of the class - The code sample is in the Transform class - The transform class is marked as public I don't have a strong opinion on private constructor and transform being marked as private/public. I think we should standardize on placing code samples in the static helper methods. That's where people are looking when using these methods. I think we need to do a general pass to make these consistent after we decide on how they should be done. Thanks, Jesse
