Hi all,

Just a 10 cents comment, but maybe a rename of public method nevertheless...

There are AccumulatorCombiningState and CombiningState interfaces, the first extends the second

The factory method StateSpecs.combiningValue returns a
StateSpec<Object, ** AccumulatorCombiningState<InputT, AccumT, OutputT> ** >

The method name seems confusing for a user, who would search for a factory method returning a CombiningState (but there is none).

Maybe StateSpecs.accumulatorCombiningValue would be a better name?

The same goes for StateSpecs.*CombiningValue methods that all return AccumulatorCombiningState but maybe the name would be too long.

WDYT?

Etienne

Reply via email to