Hadar, Thank you for doing this. Python examples are generally correct and a I left a few comments on the PR.
Thank you, Ahmet On Mon, Apr 24, 2017 at 9:03 PM, Frances Perry <[email protected]> wrote: > This is a great way for folks to contribute as part of the community > hackathon. > > I love the way these walkthroughs have instructions for all runners -- > really helps drive home the portability message ;-) > > > On Fri, Apr 21, 2017 at 4:13 PM, Hadar Hod <[email protected]> > wrote: > > > Hi everyone! > > > > Your help is needed with the WordCount [1] documentation! > > > > I'm a technical writer, continuing to work on Beam docs. In getting the > > site ready for the 2.0 release, I added a “How to run” section to each of > > the examples in the WordCount doc (staged here [2]). To be more exact, I > > added a Java section and Python section for each example (MinimalWC, WC, > > etc). Each section like this is broken down into the different runner > > options so that users can toggle to the one they need. > > > > *However(!)* the actual commands I added in the doc are guesses and have > > not been tested for correctness. I’d like to ask for your help in > finishing > > up this page; If you know the correct directions for any of the runners / > > examples / SDKs, please leave me a comment in PR 222 [3] that I have out. > > > > Your help is greatly appreciated! > > > > Thank you, > > Hadar > > > > [1] https://beam.apache.org/get-started/wordcount-example/ > > [2] *http://apache-beam-website-pull-requests.storage. > > googleapis.com/222/get-started/wordcount-example/index.html > > <http://apache-beam-website-pull-requests.storage. > googleapis.com/222/get- > > started/wordcount-example/index.html>* > > [3] https://github.com/apache/beam-site/pull/222 > > >
