On Mon, Aug 14, 2017 at 6:32 AM, Ismaël Mejía <[email protected]> wrote:

> +1 (non-binding)
>
> - Validated signatures OK
> - mvn clean verify -Prelease on both OpenJDK 1.7 and Oracle JDK 8 with
> the docker development images (WIP), both OK
> - Run WordCount on local Flink and Spark runners OK
>
> Everything looks nice, only one minor thing (not blocking at all). The
> proto generated files for python are not cleaned correctly and this
> causes the validation to complain because the maven rat plugin does
> not find the apache headers on the files  (this happens if you execute
> mvn clean verify -Prelease immediately after the validation).
>

Ismaël, could you create a JIRA issue for this (to be fixed at a future
release)?


>
> On Sun, Aug 13, 2017 at 6:52 AM, Jean-Baptiste Onofré <[email protected]>
> wrote:
> > +1 (binding)
> >
> > I do my own tests and casting my own vote ;)
> >
> > Regards
> > JB
> >
> > On 08/09/2017 07:08 AM, Jean-Baptiste Onofré wrote:
> >>
> >> Hi everyone,
> >>
> >> Please review and vote on the release candidate #3 for the version
> 2.1.0,
> >> as follows:
> >>
> >> [ ] +1, Approve the release
> >> [ ] -1, Do not approve the release (please provide specific comments)
> >>
> >>
> >> The complete staging area is available for your review, which includes:
> >> * JIRA release notes [1],
> >> * the official Apache source release to be deployed to dist.apache.org
> >> [2], which is signed with the key with fingerprint C8282E76 [3],
> >> * all artifacts to be deployed to the Maven Central Repository [4],
> >> * source code tag "v2.1.0-RC3" [5],
> >> * website pull request listing the release and publishing the API
> >> reference manual [6].
> >> * Python artifacts are deployed along with the source release to the
> >> dist.apache.org [2].
> >>
> >> The vote will be open for at least 72 hours. It is adopted by majority
> >> approval, with at least 3 PMC affirmative votes.
> >>
> >> Thanks,
> >> JB
> >>
> >> [1]
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12319527&version=12340528
> >> [2] https://dist.apache.org/repos/dist/dev/beam/2.1.0/
> >> [3] https://dist.apache.org/repos/dist/release/beam/KEYS
> >> [4] https://repository.apache.org/content/repositories/
> orgapachebeam-1020/
> >> [5] https://github.com/apache/beam/tree/v2.1.0-RC3
> >> [6] https://github.com/apache/beam-site/pull/270
> >
> >
> > --
> > Jean-Baptiste Onofré
> > [email protected]
> > http://blog.nanthrax.net
> > Talend - http://www.talend.com
>

Reply via email to