+1, thanks for all the hard work to everyone that contributed! -Tyler
On Thu, Sep 7, 2017 at 2:39 AM Ismaël Mejía <[email protected]> wrote: > +1 > A nice feature to have on Beam. Great work guys ! > > On Thu, Sep 7, 2017 at 10:21 AM, Pei HE <[email protected]> wrote: > > +1 > > > > On Thu, Sep 7, 2017 at 4:03 PM, tarush grover <[email protected]> > > wrote: > > > >> Thank you all, it was a great learning experience! > >> > >> Regards, > >> Tarush > >> > >> On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <[email protected]> > >> wrote: > >> > >> > +1 > >> > > >> > Great work guys ! > >> > Ready to help for the merge and maintain ! > >> > > >> > Regards > >> > JB > >> > > >> > On 09/07/2017 08:48 AM, Mingmin Xu wrote: > >> > > Hi all, > >> > > > >> > > On behalf of the virtual Beam SQL team[1], I'd like to propose to > merge > >> > > DSL_SQL branch into master (PR #3782 [2]) and include it in release > >> > version > >> > > 2.2.0, which will give it more visibility to other contributors and > >> > users. > >> > > The SQL feature satisfies the following criteria outlined in > >> contribution > >> > > guide[3]. > >> > > > >> > > 1. Have at least 2 contributors interested in maintaining it, and 1 > >> > > committer interested in supporting it > >> > > > >> > > * James and me will continue for new features and maintain it; > >> > > > >> > > Tyler, James and me will support it as committers; > >> > > > >> > > 2. Provide both end-user and developer-facing documentation > >> > > > >> > > * A web page[4] is added to describe the usage of SQL DSL and how it > >> > works; > >> > > > >> > > > >> > > 3. Have at least a basic level of unit test coverage > >> > > > >> > > * Totally 230 unit/integration tests, with code coverage 83.4%; > >> > > > >> > > 4. Run all existing applicable integration tests with other Beam > >> > components > >> > > and create additional tests as appropriate > >> > > > >> > > * Besides of integration tests in package > >> > org.apache.beam.sdk.extensions.sql, > >> > > there's another example in > org.apache.beam.sdk.extensions.sql.example. > >> > > BeamSqlExample. > >> > > > >> > > [1]. Special thanks to all contributors/reviewers: > >> > > > >> > > Tyler Akidau > >> > > > >> > > Davor Bonaci > >> > > > >> > > Robert Bradshaw > >> > > > >> > > Lukasz Cwik > >> > > > >> > > Tarush Grover > >> > > > >> > > Kai Jiang > >> > > > >> > > Kenneth Knowles > >> > > > >> > > Jingsong Lee > >> > > > >> > > Ismaël Mejía > >> > > > >> > > Jean-Baptiste Onofré > >> > > > >> > > James Xu > >> > > > >> > > Mingmin Xu > >> > > > >> > > [2]. https://github.com/apache/beam/pull/3782 > >> > > > >> > > [3]. https://beam.apache.org/contribute/contribution-guide/ > >> > > #merging-into-master > >> > > > >> > > [4]. https://beam.apache.org/documentation/dsls/sql/ > >> > > > >> > > Thanks! > >> > > ---- > >> > > Mingmin > >> > > > >> > > >> > -- > >> > Jean-Baptiste Onofré > >> > [email protected] > >> > http://blog.nanthrax.net > >> > Talend - http://www.talend.com > >> > > >> >
