Another breaking change was caused by https://github.com/apache/beam/commit/241d3cedd5a8fd3f360b8ec2f3a8ef5001cbca98 because it changed the build layout on the Jenkins server and our RAT rules expected to apply from a root directory. I pinged Kenneth Knowles about it and he said he was taking a look.
On Mon, Oct 23, 2017 at 11:53 AM, Raghu Angadi <rang...@google.com.invalid> wrote: > Regd (1) : > > [4] did have have a file without Apache Licence. It was fixed the next day > ( > commit > <https://github.com/apache/beam/commit/249da9b8a1e86d0fe4c3dc7b83032a > d38c3dcac0#diff-26b77e086ff8292ef54f12b22b7b767a>), > thanks to Ken Knowles who pinged me about it. > > On Mon, Oct 23, 2017 at 11:45 AM, Valentyn Tymofieiev <valen...@google.com > > > wrote: > > > Hi Beam-Dev, > > > > It's been >5 days since the last successful run of a > > beam_PreCommit_Java_MavenInstall build[1] and >4 days since last > > successful run of beam_PreCommit_Java_MavenInstall[2]. > > > > Looking at build logs I see following problems. > > > > 1. After October 17, postcommit builds started to fail with > > > > Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check > > (default) on project beam-parent: Too many files with unapproved > license: 1 > > See RAT report in: /home/jenkins/jenkins-slave/wo > > rkspace/beam_PostCommit_Java_MavenInstall/target/beam-paren > > t-2.3.0-SNAPSHOT.rat > > > > The earliest build that I see this error is Postcommit #5052 [3]. > > > > This makes me suspect [4] or [5] as a breaking change, since they change > > pom files. > > > > Questions: > > - Is there a way we can reproduce this failure locally? mvn clean verify > > passes locally for me. > > - Is there a way we can see the See RAT report mentioned in the error > > log? > > > > 2. Prior to onset of #1 Java Precommit builds no longer complete within > > allotted 150 min time. Looking at [6-8] it seems the build makes > consistent > > progress, but just does not finish on time. We can also see several > recent > > successful builds with execution time very close to time out [9-11]. > > > > I'd like to propose to increase time limit for Java precommit test suite > > from 2.5 to 4 hours. 4 hours is long time. I agree that we should > > definitely try to reduce the test execution time, and reduce flakiness. > > However we need the tests at least pass for now. If we write off failed > > test suites as 'flakes' and merge PRs without having a green test signal, > > we will have to spend more time tracing breakages such as #1. > > > > Thoughts? > > > > Thanks, > > Valentyn > > > > [1] https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/ > > [2] https://builds.apache.org/job/beam_PostCommit_Java_MavenInstall/ > > [3] https://builds.apache.org/job/beam_PostCommit_Java_MavenInst > > all/5052/changes > > > > [4] https://github.com/apache/beam/commit/d745cc9d8cc1735d3b > > c3c67ba3e2617cb7f11a8c > > [5] https://github.com/apache/beam/commit/0d8ab6cbbc762dd9f9be1b > > 3e9a26b6c9d0bb6dc3 > > > > [6] https://builds.apache.org/job/beam_PreCommit_Java_ > MavenInstall/15222/ > > [7] https://builds.apache.org/job/beam_PreCommit_Java_ > MavenInstall/15195/ > > [8] https://builds.apache.org/job/beam_PreCommit_Java_ > MavenInstall/15220/ > > > > [9] https://builds.apache.org/job/beam_PreCommit_Java_ > MavenInstall/15009/ > > [10] https://builds.apache.org/job/beam_PreCommit_Java_ > MavenInstall/15068/ > > [11] https://builds.apache.org/job/beam_PreCommit_Java_ > MavenInstall/15016/ > > > > >
