chamikaramj commented on a change in pull request #4149: [BEAM-3060] Add
Compressed TextIOIT
URL: https://github.com/apache/beam/pull/4149#discussion_r152900435
##########
File path:
sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/text/TextIOIT.java
##########
@@ -83,25 +90,82 @@ private static String appendTimestamp(String
filenamePrefix) {
return String.format("%s_%s", filenamePrefix, new Date().getTime());
}
- @Test
- public void writeThenReadAll() {
- PCollection<String> testFilenames = pipeline
- .apply("Generate sequence",
GenerateSequence.from(0).to(numberOfTextLines))
- .apply("Produce text lines", ParDo.of(new
DeterministicallyConstructTestTextLineFn()))
- .apply("Write content to files",
TextIO.write().to(filenamePrefix).withOutputFilenames())
- .getPerDestinationOutputFilenames().apply(Values.<String>create());
+ /** IO IT with no compression. */
+ @RunWith(JUnit4.class)
Review comment:
This means that this test will be picked up by all test suites (including
Java pre-commit), isn't it ? Not sure if we want to do that due to the size of
this test. Adding to post-commit tests should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
