jkff commented on a change in pull request #4145: Many simplifications to
WriteFiles
URL: https://github.com/apache/beam/pull/4145#discussion_r153294218
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -1011,14 +1002,19 @@ public void processElement(ProcessContext c) throws
Exception {
writer.open(uuid, destination);
writer.close();
completeResults.add(
- new FileResult<>(writer.getOutputFile(), shard, null, null,
destination));
+ new FileResult<>(
+ writer.getOutputFile(),
+ shard,
+ GlobalWindow.INSTANCE,
+ PaneInfo.ON_TIME_AND_ONLY_FIRING,
Review comment:
Previously the code was structured differently, and the values passed in
this particular codepath ended up being ignored. I consolidated things somewhat
to handle much of windowed and unwindowed case the same way, and made the
requirements more strict, in particular that window and pane have to be always
set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
