-1 I think the issue discovered with unbounded sources on Flink Streaming Runner is a serious regression. Good news is that there is already a fix for that: https://github.com/apache/beam/pull/4558/files
And BEAM-3587 also seems serious enough, IMHO. Btw, BEAM-3186, which seems quite serious, was also finally figured out. Best, Aljoscha > On 1. Feb 2018, at 16:00, Jean-Baptiste Onofré <[email protected]> wrote: > > So, are you casting -1 vote ? > > I guess so. > > Regards > JB > > On 02/01/2018 03:53 PM, Ismaël Mejía wrote: >> Hi, >> >> I started to test the release with Nexmark and found three issues >> (from minor to more important): >> >> 1. Small issues to run Nexmark with the release (BEAM-3531 fixed, >> BEAM-3592 in PR): >> >> BEAM-3531 Nexmark failed with NPE with DEFAULT suite >> BEAM-3592 Spark-runner profile is broken on Nexmark after move to Spark 2.x >> >> 2. Flink is broken with Unbounded sources, big enough to deserve a new >> vote. Pred: >> BEAM-3589 Flink runner breaks with ClassCastException on UnboundedSource >> >> 3. Direct runner has a relatively big performance regression when >> dealing with UnboundedSources. in particular the impact on query 7 of >> Nexmark is considerable. >> >> Just with the small SMOKE suite in my machine I get: >> >> ======================================== >> Beam 2.2.0 Beam 2.3.0 >> Query Runtime(sec) Runtime(sec) >> ======================================== >> 0000 6.4 10.6 >> 0001 5.1 10.2 >> 0002 3.0 5.8 >> 0003 3.8 6.2 >> 0004 0.9 1.4 >> 0005 5.8 11.4 >> 0006 0.8 1.4 >> 0007 193.8 1249.1 >> 0008 3.9 6.9 >> 0009 0.9 1.3 >> 0010 6.4 8.2 >> 0011 5.0 9.4 >> 0012 4.7 9.1 >> >> This can be reproduced by running this command: >> >> mvn exec:java -Dexec.mainClass=org.apache.beam.sdk.nexmark.Main >> -Pdirect-runner -Dexec.args="--runner=DirectRunner --suite=SMOKE >> --streaming=true --manageResources=false --monitorJobs=true >> --enforceEncodability=true --enforceImmutability=true" -pl >> 'sdks/java/nexmark' >> >> I think 2 and 3 deserve to be fixed or at least evaluated as important >> enough to cancel the vote. And if possible I would love to cherry-pick >> the Nexmark fixes for a future RC. >> >> On Thu, Feb 1, 2018 at 7:20 AM, Jean-Baptiste Onofré <[email protected]> >> wrote: >>> Hi all, >>> >>> just a quick reminder about the vote process: >>> >>> 1. Any vote can be changed during the vote period. A -1 vote has to be >>> argued >>> (especially if there's not change to do in the project codebase). >>> 2. For convenience to the release manager, please inform if your vote is >>> binding >>> or non-binding (the vote from PMC members are binding) >>> 3. It's not possible to "veto" a release: if we have at least 3 binding >>> votes, >>> the vote can pass. >>> 4. Please, keep only vote in the thread. If you have some tests in progress, >>> please use another thread. It would be great if the thread only contains >>> concrete votes. >>> 5. The vote duration can be extended on request. >>> >>> So, I'm extending this vote to 72 more hours to give us time to review >>> especially the dataflow worker images test and the Flink TextIO potential >>> issue. >>> >>> Thanks ! >>> Regards >>> JB >>> >>> On 01/30/2018 09:04 AM, Jean-Baptiste Onofré wrote: >>>> Hi everyone, >>>> >>>> Please review and vote on the release candidate #1 for the version 2.3.0, >>>> as >>>> follows: >>>> >>>> [ ] +1, Approve the release >>>> [ ] -1, Do not approve the release (please provide specific comments) >>>> >>>> >>>> The complete staging area is available for your review, which includes: >>>> * JIRA release notes [1], >>>> * the official Apache source release to be deployed to dist.apache.org [2], >>>> which is signed with the key with fingerprint C8282E76 [3], >>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>> * source code tag "v2.3.0-RC1" [5], >>>> * website pull request listing the release and publishing the API reference >>>> manual [6]. >>>> * Java artifacts were built with Maven 3.3.9 and Oracle JDK 1.8.0_111. >>>> * Python artifacts are deployed along with the source release to the >>>> dist.apache.org [2]. >>>> >>>> The vote will be open for at least 72 hours. It is adopted by majority >>>> approval, >>>> with at least 3 PMC affirmative votes. >>>> >>>> Thanks, >>>> JB >>>> >>>> [1] >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12341608 >>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.3.0/ >>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>> [4] https://repository.apache.org/content/repositories/orgapachebeam-1026/ >>>> [5] https://github.com/apache/beam/tree/v2.3.0-RC1 >>>> [6] https://github.com/apache/beam-site/pull/381 >>>> >>> >>> -- >>> Jean-Baptiste Onofré >>> [email protected] >>> http://blog.nanthrax.net >>> Talend - http://www.talend.com > > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com
