since it breaks only examples not sure it does worth yet another reroll (which means already a 2 weeks delay on the plan). Users will be affected the same anyway - and in an expected way until beam handles classloaders per transform. A note in the side is fine probably.
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> 2018-02-09 7:23 GMT+01:00 Chamikara Jayalath <chamik...@google.com>: > > > On Thu, Feb 8, 2018 at 10:18 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > >> It means a RC3 then. >> >> Basically, we have two options: >> >> 1. I cancel RC2, to include PR 4645 and cut a RC3. It can be done super >> fast >> (today). >> > > +1 for option 1 since IMO we should not release with quickstart broken for > Spark. > > >> 2. We continue RC2 vote and we add a note about shading (as I did for the >> TextIO >> issue with Flink runner). >> >> I'm more in favor of 1 as the fix is already there and cutting a release >> is >> super fast for me. >> >> Thoughts ? >> >> Regards >> JB >> >> On 02/09/2018 07:06 AM, Chamikara Jayalath wrote: >> > +1 for continuing the release after the immediate fix >> > (https://github.com/apache/beam/pull/4645). I don't >> > think https://issues.apache.org/jira/browse/BEAM-3519 is due to a >> recent update >> > to google-cloud-platform module so the issue likely existed in some >> form in >> > previous releases as well. >> > >> > - Cham >> > >> > On Thu, Feb 8, 2018 at 9:47 PM Romain Manni-Bucau < >> rmannibu...@gmail.com >> > <mailto:rmannibu...@gmail.com>> wrote: >> > >> > IMHO it is not a blocker but an incompatibility between spark and >> some IO >> > stack. Trivial workaround is to shade the io before importing it in >> its >> > project. Amternative is to wrap IO in custom classloaders. >> > >> > Didnt check for this one but it is a common beam issue to have >> conflicts >> > between runners/io or even 2 ios so it shouldnt block a release by >> itself >> > until beam aims to solve properly conflicts - which means without >> shading >> > which breaks the io ecosystem on the user side. >> > >> > Just my 2cts >> > >> > Le 9 févr. 2018 06:07, "Jean-Baptiste Onofré" <j...@nanthrax.net >> > <mailto:j...@nanthrax.net>> a écrit : >> > >> > Is it specific to this release ? I think it was like this >> before no ? >> > >> > Regards >> > JB >> > >> > On 02/09/2018 12:48 AM, Kenneth Knowles wrote: >> > > Since root cause is https://issues.apache.org/ >> jira/browse/BEAM-3519 I >> > marked it >> > > a blocker so we can discuss fixes or workarounds there. >> > > >> > > On Thu, Feb 8, 2018 at 1:24 PM, Lukasz Cwik <lc...@google.com >> > <mailto:lc...@google.com> >> > > <mailto:lc...@google.com <mailto:lc...@google.com>>> wrote: >> > > >> > > I validated several of the quickstarts and updated the >> spreadsheet and >> > > currently am voting -1 for this release due to Spark >> runner >> > failing. Filed >> > > https://issues.apache.org/jira/browse/BEAM-3668 >> > > <https://issues.apache.org/jira/browse/BEAM-3668> with >> the full >> > details. >> > > >> > > >> > > On Thu, Feb 8, 2018 at 10:32 AM, Valentyn Tymofieiev >> > <valen...@google.com <mailto:valen...@google.com> >> > > <mailto:valen...@google.com <mailto:valen...@google.com>>> >> wrote: >> > > >> > > Yes (thanks >> > Kenn!): https://s.apache.org/beam-2.3.0-release-validation >> > > <https://s.apache.org/beam-2.3.0-release-validation> >> > > >> > > On Thu, Feb 8, 2018 at 10:14 AM, Eugene Kirpichov >> > <kirpic...@google.com <mailto:kirpic...@google.com> >> > > <mailto:kirpic...@google.com <mailto: >> kirpic...@google.com>>> >> > wrote: >> > > >> > > Do we have a release validation spreadsheet for >> this one? >> > > >> > > On Thu, Feb 8, 2018 at 9:30 AM Ahmet Altay >> > <al...@google.com <mailto:al...@google.com> >> > > <mailto:al...@google.com <mailto:al...@google.com>>> >> wrote: >> > > >> > > +1 >> > > >> > > I verified python quick start, mobile gaming >> examples, >> > streaming >> > > on Direct and Dataflow runners. Thank you JB! >> > > >> > > On Thu, Feb 8, 2018 at 2:27 AM, Romain >> Manni-Bucau >> > > <rmannibu...@gmail.com <mailto: >> rmannibu...@gmail.com> >> > <mailto:rmannibu...@gmail.com <mailto:rmannibu...@gmail.com>>> >> wrote: >> > > >> > > +1 (non-binding), thanks JB for the >> effort! >> > > >> > > >> > > Romain Manni-Bucau >> > > @rmannibucau <https://twitter.com/ >> rmannibucau> | Blog >> > > <https://rmannibucau.metawerx.net/> | >> Old Blog >> > > <http://rmannibucau.wordpress.com> >> | Github >> > > <https://github.com/rmannibucau> | >> LinkedIn >> > > <https://www.linkedin.com/in/rmannibucau> | >> Book >> > > >> > <https://www.packtpub.com/application-development/java- >> ee-8-high-performance> >> > > >> > > 2018-02-08 11:12 GMT+01:00 Ismaël Mejía >> > <ieme...@gmail.com <mailto:ieme...@gmail.com> >> > > <mailto:ieme...@gmail.com >> > <mailto:ieme...@gmail.com>>>: >> > > >> > > +1 (binding) >> > > >> > > Validated SHAs + tag vs source.zip >> file. >> > > Run mvn clean install -Prelease OK >> > > Validated that the 3 regressions >> reported for >> > RC1 were >> > > fixed. >> > > Run Nexmark on Direct/Flink runner on >> local >> > mode, no >> > > regressions now. >> > > Installed python version on >> virtualenv and run >> > wordcount >> > > with success. >> > > >> > > On Thu, Feb 8, 2018 at 6:37 AM, >> Jean-Baptiste >> > Onofré >> > > <j...@nanthrax.net <mailto: >> j...@nanthrax.net> >> > <mailto:j...@nanthrax.net <mailto:j...@nanthrax.net>>> wrote: >> > > > Hi everyone, >> > > > >> > > > Please review and vote on the >> release >> > candidate #2 for >> > > the version 2.3.0, as >> > > > follows: >> > > > >> > > > [ ] +1, Approve the release >> > > > [ ] -1, Do not approve the release >> (please >> > provide >> > > specific comments) >> > > > >> > > > >> > > > The complete staging area is >> available for your >> > > review, which includes: >> > > > * JIRA release notes [1], >> > > > * the official Apache source >> release to be >> > deployed to >> > > dist.apache.org < >> http://dist.apache.org> >> > <http://dist.apache.org> [2], >> > > > which is signed with the key with >> > fingerprint C8282E76 >> > > [3], >> > > > * all artifacts to be deployed to >> the Maven >> > Central >> > > Repository [4], >> > > > * source code tag "v2.3.0-RC2" [5], >> > > > * website pull request listing the >> release and >> > > publishing the API reference >> > > > manual [6]. >> > > > * Java artifacts were built with >> Maven 3.3.9 and >> > > Oracle JDK 1.8.0_111. >> > > > * Python artifacts are deployed >> along with >> > the source >> > > release to the >> > > > dist.apache.org < >> http://dist.apache.org> >> > <http://dist.apache.org> [2]. >> > > > >> > > > The vote will be open for at least >> 72 hours. >> > It is >> > > adopted by majority approval, >> > > > with at least 3 PMC affirmative >> votes. >> > > > >> > > > Thanks, >> > > > JB >> > > > >> > > > [1] >> > > > >> > > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> projectId=12319527&version=12341608 >> > > >> > <https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> projectId=12319527&version=12341608> >> > > > [2] >> > https://dist.apache.org/repos/dist/dev/beam/2.3.0/ >> > > >> > <https://dist.apache.org/repos/dist/dev/beam/2.3.0/> >> > > > [3] >> > > >> > https://dist.apache.org/repos/dist/release/beam/KEYS >> > > >> > <https://dist.apache.org/repos/dist/release/beam/KEYS> >> > > > [4] >> > > >> > https://repository.apache.org/content/repositories/ >> orgapachebeam-1027/ >> > > >> > <https://repository.apache.org/content/repositories/ >> orgapachebeam-1027/> >> > > > [5] >> > https://github.com/apache/beam/tree/v2.3.0-RC2 >> > > <https://github.com/apache/ >> beam/tree/v2.3.0-RC2> >> > > > [6] https://github.com/apache/ >> beam-site/pull/381 >> > > <https://github.com/apache/ >> beam-site/pull/381> >> > > > -- >> > > > Jean-Baptiste Onofré >> > > > jbono...@apache.org >> > <mailto:jbono...@apache.org> <mailto:jbono...@apache.org >> > <mailto:jbono...@apache.org>> >> > > > http://blog.nanthrax.net >> > > > Talend - http://www.talend.com >> > > >> > > >> > > >> > > >> > > >> > > >> > >> > -- >> > Jean-Baptiste Onofré >> > jbono...@apache.org <mailto:jbono...@apache.org> >> > http://blog.nanthrax.net >> > Talend - http://www.talend.com >> > >> >> -- >> Jean-Baptiste Onofré >> jbono...@apache.org >> http://blog.nanthrax.net >> Talend - http://www.talend.com >> >
