I'm happy to deal with any needed fixup on the Go SDK side in either case. On Tue, Mar 6, 2018 at 3:20 PM, Lukasz Cwik <lc...@google.com> wrote:
> Can we open up the pair of commits so that master gets reverted and the Go > SDK merges from master plus another rollback? > > On Tue, Mar 6, 2018 at 2:42 PM, Kenneth Knowles <k...@google.com> wrote: > >> Hi all, >> >> You may have noticed that our tests are red. A pull request that was >> meant for the Go SDK branch accidentally got merged onto the master branch. >> Things have been merged to master since then. >> >> I've opened a revert at https://github.com/apache/beam/pull/4808 >> >> The next time there is a master to go-sdk merge it will need to be >> re-reverted. >> >> Two other options are (1) leave it there and disable it in whatever way >> and (2) rebase dropping the commit and force push master (breaks all >> checkouts that are past it). >> >> Kenn >> > >
