+1, Thank you JB. JB, python wheel files are not included in https://dist.apache.org/repos/ dist/dev/beam/2.5.0/. Since Yifan already validated the wheels files built by Boyuan, could you copy those files to the release folder before closing the vote?
On Wed, Jun 20, 2018 at 1:19 PM, Pablo Estrada <pabl...@google.com> wrote: > Since we use git-published archives to push to dist.apache.org, we only > need to add an exclusion of those files in .gitattributes. Here's the PR to > fix that: https://github.com/apache/beam/pull/5699 > > Here's an example of a published archive from the branch with that > exclusion: https://github.com/pabloem/incubator-beam/ > archive/v2.5.0-TEST-ARCHIVE.zip > Best > -P. > > On Wed, Jun 20, 2018 at 11:00 AM Ahmet Altay <al...@google.com> wrote: > >> I support Kenn's proposal of removing binary artifacts and otherwise >> keeping the RC2. We have done it in the pas with similar binary files that >> were unintended. At the same time, it will follow the suggestion from >> LEGAL-288. As a follow up we can build this removal into our release >> process until there is a resolution to the issue. >> >> Ahmet >> >> On Wed, Jun 20, 2018 at 10:46 AM, Kenneth Knowles <k...@google.com> wrote: >> >>> I had a chance to look closely. Bringing some details to this thread. >>> >>> We have the following Apache 2.0 licensed files in our source release >>> zip: >>> >>> beam-release-2.5.0/gradle.properties >>> beam-release-2.5.0/gradle/ >>> beam-release-2.5.0/gradle/wrapper/ >>> beam-release-2.5.0/gradle/wrapper/gradle-wrapper.jar >>> beam-release-2.5.0/gradle/wrapper/gradle-wrapper.properties >>> beam-release-2.5.0/gradlew >>> beam-release-2.5.0/gradlew.bat >>> >>> LEGAL-288 is unresolved, but looks like the mostly likely result is that >>> we must remove gradle-wrapper.jar. This matches ASF policy about putting >>> any binary artifact in the source zip. Apache Fineract is one place we >>> could look for an example of doing exactly this. >>> >>> In the past, we have manually tweaked the zip to remove extraneous files >>> without rolling a new RC & vote. Can do that here, since the release has >>> been thoroughly vetted? >>> >>> Kenn >>> >>> On Wed, Jun 20, 2018 at 10:25 AM Davor Bonaci <da...@apache.org> wrote: >>> >>>> Sorry, no -1, at least not at this time. This is only a suspected >>>> issue. Even the referenced issue is not a formal ruling, with some >>>> dissenting opinions, and a programatic suggestion that most are comfortable >>>> with. (Personally, I probably lean on the side that inclusion of this file >>>> is fine.) >>>> >>>> But, it is something that warrants a discussion... >>>> >>>> On Wed, Jun 20, 2018 at 9:47 AM, Lukasz Cwik <lc...@google.com> wrote: >>>> >>>>> Davor, please -1 the release if you believe LEGAL-288 applies. >>>>> >>>>> On Wed, Jun 20, 2018 at 9:37 AM Davor Bonaci <da...@apache.org> wrote: >>>>> >>>>>> Please take a peek at LEGAL-288 [1], which I learned about recently >>>>>> in the context of another project. Looks like an issue, requiring a new >>>>>> RC, >>>>>> but I didn't have a chance to look closely. >>>>>> >>>>>> Thanks. >>>>>> >>>>>> Davor >>>>>> >>>>>> [1] https://issues.apache.org/jira/browse/LEGAL-288 >>>>>> >>>>>> On Wed, Jun 20, 2018 at 9:17 AM, Pablo Estrada <pabl...@google.com> >>>>>> wrote: >>>>>> >>>>>>> +1 (binding) >>>>>>> >>>>>>> On Wed, Jun 20, 2018 at 9:08 AM Lukasz Cwik <lc...@google.com> >>>>>>> wrote: >>>>>>> >>>>>>>> +1 (binding) >>>>>>>> >>>>>>>> On Tue, Jun 19, 2018 at 10:39 PM Jean-Baptiste Onofré < >>>>>>>> j...@nanthrax.net> wrote: >>>>>>>> >>>>>>>>> +1 (binding) >>>>>>>>> >>>>>>>>> Regards >>>>>>>>> JB >>>>>>>>> >>>>>>>>> On 17/06/2018 07:18, Jean-Baptiste Onofré wrote: >>>>>>>>> > Hi everyone, >>>>>>>>> > >>>>>>>>> > Please review and vote on the release candidate #2 for the >>>>>>>>> version >>>>>>>>> > 2.5.0, as follows: >>>>>>>>> > >>>>>>>>> > [ ] +1, Approve the release >>>>>>>>> > [ ] -1, Do not approve the release (please provide specific >>>>>>>>> comments) >>>>>>>>> > >>>>>>>>> > NB: this is the first release using Gradle, so don't be too >>>>>>>>> harsh ;) A >>>>>>>>> > PR about the release guide will follow thanks to this release. >>>>>>>>> > >>>>>>>>> > The complete staging area is available for your review, which >>>>>>>>> includes: >>>>>>>>> > * JIRA release notes [1], >>>>>>>>> > * the official Apache source release to be deployed to >>>>>>>>> dist.apache.org >>>>>>>>> > [2], which is signed with the key with fingerprint C8282E76 [3], >>>>>>>>> > * all artifacts to be deployed to the Maven Central Repository >>>>>>>>> [4], >>>>>>>>> > * source code tag "v2.5.0-RC2" [5], >>>>>>>>> > * website pull request listing the release and publishing the API >>>>>>>>> > reference manual [6]. >>>>>>>>> > * Java artifacts were built with Gradle 4.7 (wrapper) and >>>>>>>>> OpenJDK/Oracle >>>>>>>>> > JDK 1.8.0_172 (Oracle Corporation 25.172-b11). >>>>>>>>> > * Python artifacts are deployed along with the source release to >>>>>>>>> the >>>>>>>>> > dist.apache.org [2]. >>>>>>>>> > >>>>>>>>> > The vote will be open for at least 72 hours. It is adopted by >>>>>>>>> majority >>>>>>>>> > approval, with at least 3 PMC affirmative votes. >>>>>>>>> > >>>>>>>>> > Thanks, >>>>>>>>> > JB >>>>>>>>> > >>>>>>>>> > [1] >>>>>>>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa? >>>>>>>>> projectId=12319527&version=12342847 >>>>>>>>> > [2] https://dist.apache.org/repos/dist/dev/beam/2.5.0/ >>>>>>>>> > [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>>>>>>> > [4] https://repository.apache.org/content/repositories/ >>>>>>>>> orgapachebeam-1043/ >>>>>>>>> > [5] https://github.com/apache/beam/tree/v2.5.0-RC2 >>>>>>>>> > [6] https://github.com/apache/beam-site/pull/463 >>>>>>>>> > >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Jean-Baptiste Onofré >>>>>>>>> jbono...@apache.org >>>>>>>>> http://blog.nanthrax.net >>>>>>>>> Talend - http://www.talend.com >>>>>>>>> >>>>>>>> -- >>>>>>> Got feedback? go/pabloem-feedback >>>>>>> <https://goto.google.com/pabloem-feedback> >>>>>>> >>>>>> >>>>>> >>>> >> -- > Got feedback? go/pabloem-feedback > <https://goto.google.com/pabloem-feedback> >
