This is awesome, thanks to everybody involved! It's so good to have ./gradlew compileJava compileTestJava not produce heaps of warnings like it used to.
On Wed, Jun 27, 2018 at 9:52 AM Andrew Pilloud <[email protected]> wrote: > Looking at the diff I think you can replace "Default Setting" with "Only > Setting". This is Awesome! Thanks guys! > > Andrew > > On Wed, Jun 27, 2018 at 9:50 AM Kenneth Knowles <[email protected]> wrote: > >> Awesome! Can we remove the ability to disable it? :-) :-) :-) or anyhow >> make it more obscure, not like an expected top-level config choice. >> >> Kenn >> >> On Wed, Jun 27, 2018 at 9:45 AM Tim <[email protected]> wrote: >> >>> Thanks also to you Scott >>> >>> Tim >>> >>> On 27 Jun 2018, at 18:39, Scott Wegner <[email protected]> wrote: >>> >>> Six weeks ago [1] we began an effort to improve the quality of the Java >>> codebase via ErrorProne static analysis, and promoting compiler warnings to >>> errors. As of today, all of our Java projects have been migrated and this >>> is now the default setting for Beam [2]. >>> >>> This was a community effort. The cleanup spanned 48 JIRA issues [3] and >>> 46 pull requests [4]. I want to give a big thanks to everyone who helped >>> out: Ismaël Mejía, Tim Robertson, Cade Markegard, and Teng Peng. >>> >>> Thanks! >>> >>> [1] >>> https://lists.apache.org/thread.html/cdc729b6349f952d8db78bae99fff74b06b60918cbe09344e075ba35@%3Cdev.beam.apache.org%3E >>> <https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E> >>> [2] https://github.com/apache/beam/pull/5773 >>> [3] >>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20BEAM%20AND%20labels%20%3D%20errorprone >>> >>> [4] >>> https://github.com/apache/beam/pulls?utf8=%E2%9C%93&q=is%3Apr+errorprone+merged%3A%3E%3D2018-05-16+ >>> >>> >>>
