It failed again. I'm pinging infra a new time. Sorry about that.
Regards JB Le 29 juin 2018 à 08:52, à 08:52, Reuven Lax <[email protected]> a écrit: >"retest this please" also seems to not be working right now. > >On Thu, Jun 28, 2018 at 5:49 PM Reuven Lax <[email protected]> wrote: > >> I've pushed changes that definitely affect code, and seen no tests at >all >> being triggered. I also wonder if something isn't working quite right >with >> this filtering. >> >> On Thu, Jun 28, 2018 at 5:16 PM Robin Qiu <[email protected]> wrote: >> >>> My PR with only changes in Java also triggered Python ("Run Python >>> PreCommit") and Go ("Run Go PreCommit") tests. Is that the expected >>> behavior? >>> https://github.com/apache/beam/pull/5787 >>> >>> On Wed, Jun 27, 2018 at 5:04 PM Ahmet Altay <[email protected]> >wrote: >>> >>>> Two of my PRs with python changes did not trigger any pre-commits. >Could >>>> it be related to this change? >>>> >>>> https://github.com/apache/beam/pull/5768 >>>> https://github.com/apache/beam/pull/5800 >>>> >>>> Ahmet >>>> >>>> >>>> >>>> On Tue, Jun 26, 2018 at 2:30 PM, Andrew Pilloud ><[email protected]> >>>> wrote: >>>> >>>>> Awesome! This will save so much time running tests. >>>>> >>>>> On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou <[email protected]> >wrote: >>>>> >>>>>> Thanks Scott! It's nice to have this feature. >>>>>> >>>>>> On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada ><[email protected]> >>>>>> wrote: >>>>>> >>>>>>> This is great. Reducing load on infrastructure should help Beam >scale >>>>>>> into a larger project : ) - Thanks Scott! >>>>>>> >>>>>>> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> By popular demand [1], filtered pre-commit triggering is now >>>>>>>> re-enabled. Now when submitting pull request, only pre-commit >tests for >>>>>>>> your affected files will run: if you change just the Go SDK, >you'll no >>>>>>>> longer need to run Java pre-commits. >>>>>>>> >>>>>>>> Last time we introduced this change it regressed our ability to >run >>>>>>>> other pre-commits via trigger phrase ("Run Java PreCommit"); >this is now >>>>>>>> fixed by splitting the Jenkins jobs by trigger condition [2]. >>>>>>>> >>>>>>>> Enjoy! >>>>>>>> >>>>>>>> >>>>>>>> [1] >>>>>>>> >https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E >>>>>>>> [2] https://github.com/apache/beam/pull/5757 >>>>>>>> >>>>>>> -- >>>>>>> Got feedback? go/pabloem-feedback >>>>>>> <https://goto.google.com/pabloem-feedback> >>>>>>> >>>>>> >>>>
