Thanks for opinions! I'll take care of this: https://issues.apache.org/jira/browse/BEAM-4691 (fyi)
Łukasz śr., 27 cze 2018 o 20:29 Scott Wegner <sweg...@google.com> napisał(a): > The Jenkins source files are naming according to the Jenkins jobs they > produce, which are named with Snake_Case. However this doesn't seem like a > requirement, and I'm all in favor of keeping things and idiomatic as > possible. So +1 to CamelCase.groovy > > FYI, the official Groovy style guide is here: > http://groovy-lang.org/style-guide.html#_classes_as_first_class_citizens, > although it doesn't explicitly touch on naming conventions. > > On Wed, Jun 27, 2018 at 9:25 AM Kenneth Knowles <k...@google.com> wrote: > >> SGTM. The underscores are more-or-less substituting for directories. >> Maybe we can just put them in directories? >> >> On Wed, Jun 27, 2018 at 9:18 AM Lukasz Cwik <lc...@google.com> wrote: >> >>> I don't really have a strong preference. >>> >>> On Wed, Jun 27, 2018 at 9:13 AM Łukasz Gajowy <lukasz.gaj...@gmail.com> >>> wrote: >>> >>>> Hi all, >>>> >>>> I think we should change the naming convention that we have in >>>> jenkins .groovy files. AFAIK, groovy is CamelCase, and we use snake_case >>>> names there. I suppose this is because we wanted to reflect jenkins job >>>> names (do we need this?) >>>> >>>> IMO, the convention should be CamelCase for all .groovy files (both >>>> actual job files and helper class files). >>>> >>>> WDYT? >>>> >>>> Łukasz >>>> >>>
