I can do the review as well, as I did the original ES IO with Etienne. Regards JB
On 10/08/2018 17:25, Alexey Romanenko wrote: > Hi Tormod, > > Thank you for your contribution! > > As I see in this PR, there are two suggestions for reviewers - Etienne > Chauchot (echauchot) and Ismaël Mejía (iemejia). So, you can send a > request for review to them directly from your PR. > AFAIK, they are on holidays for the moment but they will back soon. > > Btw, do you have a Jira for this PR? If yes then it would be useful to > add Jira issue id to PR name and to commit message. If not, please, > create a Jira as well. > Please, see this Contribution Guide section [1] for details. > > [1] https://beam.apache.org/contribute/#pull-requests > > >> On 10 Aug 2018, at 15:41, Tormod Haavi <[email protected] >> <mailto:[email protected]>> wrote: >> >> I had to fork the elasticsearch client for a project I am working on >> and created a pull request #6200 "Java elasticsearch client support >> for reading documents with metadata." Who should I mention as reviewer? >> >> I just added a new Reader option "withMetadata" in order to access the >> whole elastic result document in stead of just the _source-node. In my >> case, I needed access to the document id. >> >> Tormod Haavi > -- Jean-Baptiste Onofré [email protected] http://blog.nanthrax.net Talend - http://www.talend.com
