I think this should be an integration test if it requires more access than the current ValidatesRunner tests.
Although the ValidatesRunner and integration tests are similar, the intent is that the validates runner tests are smaller and more like component tests, and there have been discusions on fusing the validates runner tests into a smaller set of pipelines. On Mon, Aug 27, 2018 at 11:27 AM Robin Qiu <[email protected]> wrote: > Hello everyone, > > I am writing a test [1] for the support of @RequiresStableInput annotation > in Java SDK [2]. For the test to work, I need to have a ParDo make some > side effect (e.g. writing to a file system). However, ValidatesRunner tests > in Beam currently cannot depend on external states (cannot write to file > systems). So I am wondering if it is a good idea to allow ValidatesRunner > tests to have access to file systems. This way we can create more flexible > ValidatesRunner tests. > > I could make this test a integration test to get access to file systems > (e.g. like WordCountIT.java [3]). But functionally I think this test should > be a ValidatesRunner test, because it is testing the support of some SDK > features on runners. > > So what do you think? Any suggestions or concerns are appreciated. > > Best, > Robin > > [1] https://github.com/apache/beam/pull/6220 > [2] > https://docs.google.com/document/d/117yRKbbcEdm3eIKB_26BHOJGmHSZl1YNoF0RqWGtqAM/edit# > [3] > https://github.com/apache/beam/blob/master/examples/java/src/test/java/org/apache/beam/examples/WordCountIT.java > >
