As I understand, Tim's concern is the accuracy of the release notes, and +1 for correcting them. In the end it does not matter that much to the users when a release was proposed to be cut vs. when it actually happened, but what they get with the release.
Perhaps between the contributors we could going forward just mention as of what commit the actual release occurred? Ultimately it is reviewer/contributor responsibility that issues they work on are marked with the correct fix version. There was some related discussion on when to set the fix version on issues. I think that it is best to defer that until the PR is merged and the issue resolved, to avoid confusion. On Mon, Oct 8, 2018 at 9:11 AM Andrew Pilloud <apill...@google.com> wrote: > Keep reading the proposal thread and you'll find: "We should follow the > calendar and aim to cut on 8/29, not 9/7 as I incorrectly wrote earlier." > There were several folowup emails in the thread with reminders of the > release cut date. Is there something we should do to better communicate > release cuts in the future? > > > https://lists.apache.org/thread.html/c4da2a5594d22121b5864662e64a027148993b5e0187ce5beda2714e@%3Cdev.beam.apache.org%3E > > Andrew > > On Mon, Oct 8, 2018 at 3:17 AM Tim Robertson <timrobertson...@gmail.com> > wrote: > >> Hi folks >> >> Our release notes [1] for 2.7.0 say that Beam supports Elasticsearch 6 ( >> BEAM-5107 <https://issues.apache.org/jira/browse/BEAM-5107>). The 2.7.0 >> code [2] however does not seem to, while master does [3]. The PR [4] was >> merged on the 6th September and in the 2.7.0 chat I see that Charles >> announced: >> >> I will cut the initial 2.7.0 release branch on September 7. >> >> Is this a case of unfortunate timing (it was cut early?) and we just >> overlooked cherry picking that commit do you think? >> >> Do we correct release notes when mistakes are spotted? >> >> Thanks, >> Tim >> >> [1] >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12343654 >> [2] >> https://github.com/apache/beam/blob/release-2.7.0/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java#L1243 >> [3] >> https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java#L1268 >> [4] https://github.com/apache/beam/pull/6211 >> >
