Not certain, it looks like we should have been caching the executor within the GcsUtil as a static instance instead of creating one each time. Could have been missed during code review / slow code changes over time. GcsUtil is not well "loved".
On Thu, Nov 8, 2018 at 11:00 AM Udi Meiri <[email protected]> wrote: > HI, > I've identified a memory leak when GcsUtil.java instantiates a > ThreadPoolExecutor (https://issues.apache.org/jira/browse/BEAM-6018). > The code uses the getExitingExecutorService > <https://github.com/apache/beam/blob/279a05604b83a54e8e5a79e13d8761f94841f326/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java#L551> > wrapper, > which leaks memory. The question is, why is that wrapper necessary > if executor.shutdown(); is later unconditionally called? >
